From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0067.outbound.protection.outlook.com [104.47.38.67]) by dpdk.org (Postfix) with ESMTP id BB1E34C90 for ; Mon, 8 Oct 2018 13:28:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IRL6wPzJVRr6mQ64f6roQTxUuSNJN59HjcVHdeMdXK4=; b=bDnZCxsSPVOw24Xpy3O9c/NTMEe1h3sftVkFg6pD+pDsgUrN77p9ATMkuEbBSp+ywkwsXrzXCrlo1IefcfTpGo0pIuY1dNP0GznlC6ZWBZPNoViS5NZMSfciLwDgsvnfuya8BiXjuRc0SODrSscKEckcFIpcHtheIF/4LAsxD9E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by SN6PR07MB4910.namprd07.prod.outlook.com (2603:10b6:805:39::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Mon, 8 Oct 2018 11:28:14 +0000 To: Ferruh Yigit , Bruce Richardson , Pablo de Lara Cc: Jerin Jacob , Narayana Prasad , dev@dpdk.org, Thomas Monjalon References: <1538995285-2040-1-git-send-email-anoob.joseph@caviumnetworks.com> <09bc1e17-661a-ab12-5ca0-215c7cdfe5ee@intel.com> From: "Joseph, Anoob" Message-ID: <98620a3a-2968-be0b-4690-ee4d6dad1101@caviumnetworks.com> Date: Mon, 8 Oct 2018 16:59:22 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <09bc1e17-661a-ab12-5ca0-215c7cdfe5ee@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: PN1PR0101CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::13) To SN6PR07MB4910.namprd07.prod.outlook.com (2603:10b6:805:39::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbf9344b-efdd-48f7-4db7-08d62d11242c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4910; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 3:GncMjraYZoAYnUZpW2V4Ja1eJpAvyVUYumHYZ2U1dIXlmbaqqXOTvQdqbOG0ojl1awUIWJ9eqlvPXwgPMjalu+EGEXdwggdDqK4Jh1GNdHRhmZHHfeNpFOWOX4DIUA4padkW90WKxGaSs7EShU/ibTRpqxhm8RRKK78bNChNAP1mLqdUewuqYorvS9VMI17tNs8BWU4ry/1BdssVN/ewtK1QhJ8PfUEqjCDMjO2C57VjkB5gtFZMu78iOzi6WWLK; 25:I9NM1WOV2dd0Uq8yP0oQCbuJwzZQtbpAOjcdoCotMqIPQe09I+5M6jFNYbt33dxEcDOVEsgAzFuI9D6qmCkEnOPfwB+rf5fwXfLEoyQVCRL4/9VQJcntZfpX6DnmVqwJy3ud3fHiet9/crEGtEA7uMFhzh6Z1fuDgzW7peBJFXw5OYWLoCVa2ip3PqFSgYE9tToBw6ALO7R+5Ln8qZF2LGSiHmC43uIW4DzP5xldpAW+exmbugYDnoPkaYgzHVAf94SzYbUcIOVE9VutJdvUQtQnkfIz43OktuE1YAT3TYthv+nC9IiPXf/I5TL82beN+Kp3G93o4RqW5tPl8WlrlA==; 31:hrniY7o3jxbV2iC0H8FTuLr/JpmAqtp4QrRQ5zuB7msQQAX0ogvuLUtEy1kBqOlxk1gUiiaehLAnVmeyV8Nr7rSpl/5m4yBodeIR6tWcQQazhG/TI1nZu4erfCVbrOpoag0U7szY1cnsW9omDohKB17w+ixj0YLc4VT9eLTikz80nHqDmSSPe/D/+b7YyxwNchjb+2DLruYXpFk8tKxSNAnOwITeOZdDNVVelwBBM5k= X-MS-TrafficTypeDiagnostic: SN6PR07MB4910: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 20:FEQPNvP3Jfpcjf52Du1VZcvj9+K4awzcBYEXmY1ABahenaAwp2Se3HP9/+WiwpXpYb/YrVrPeT8Yslgqa5fCqi16kajdFi2kLjheOx05Dgi3Mj0T49vN5pHV523gil1rICvSlDm0socea/zhAcJjxmVl13hhxLmixi6GCfKLlKhTcJ8bTAV3A1FIjw82m7LzsanuZT4UwPzvQz1YFoAkJRZTVW4vZ1KJ+SN4LGPXilCnwv794gcJxlQREmzQK/MoiMZp4X7NibsRCf1Q+IysmPSsfdVUAMfXXU575f392to6I1Z+NihL2tAZDEaZ2n/gxnPdLFuGN+3GNGCLAj2BsQD2R2l/g9z7AVHa+wf4LY4ppmt4E7LabvChTxRcEfUckDaTKMrFspfmWCEsvJpS2zH1Ubs/j3eqz8PQv6eKjk9F8TrOC1N70QNTj+416HhcO5cdmljtmhRy8tY13ku3syRx8jk1GFmMeGncWxKQQBYWLxx/zXbxfK29L/F2nl0iPgeeSOtpB/W00KdNFxa3RzbzrdvnNCGMrw1J+VVLE2+BD9N8AGssU9lbXjWlwglALwUPWnZm5oEGBK3gvmTAloPqumkPPVyut5TJQbnb61g= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(131327999870524); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051); SRVR:SN6PR07MB4910; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4910; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 4:t7TrLfVMkMDQnrs34Gjg1khgAyMo5p4Dozxyr/iBoQWR83wm7RNlDEsWZn5lrAgXA6bZcMyGPg7y7zDkcP2bc52YkaecUqgk26H4LUkyKiqW5WjH+YGn7W+L43aRCGzEbAQ3GxalOy5hvDVVbKun+wYu515Wn+htVCIbfhn9Hj0w4JmCtE1oUgm2Qg80wzvM7FWIBc/XRgUXxZ4WTd7RO5PI6dRdTNZGF5Z/VqWgR/Ooyyj0T+VRzHQQeURESI8Id7/4qDGbbm5efUFK8oVi29Uq7TKuOa7SY9Ujc3EHkX4lK+W/DIEG4W+KWfGfTEbD81djkbsZXTPXvtaIafyR3+kgWvn4Xr88D4IO0ZoMq9w= X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(39860400002)(366004)(136003)(376002)(346002)(189003)(199004)(2906002)(67846002)(486006)(81156014)(54906003)(110136005)(97736004)(53546011)(55236004)(50466002)(386003)(53936002)(81166006)(230700001)(58126008)(229853002)(72206003)(476003)(64126003)(7736002)(6246003)(966005)(2486003)(16576012)(68736007)(11346002)(6306002)(446003)(8676002)(478600001)(4326008)(52146003)(23676004)(956004)(2616005)(8936002)(305945005)(316002)(76176011)(36756003)(52116002)(65806001)(65826007)(6666003)(186003)(16526019)(31696002)(47776003)(26005)(14444005)(65956001)(77096007)(6116002)(66066001)(3846002)(6486002)(31686004)(42882007)(106356001)(105586002)(25786009)(5660300001)(3260700006); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4910; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTEwOzIzOnFMZFRNNUZoNGlTK2xwTU1tNTFuYUlXUk1y?= =?utf-8?B?VFk1RTd0SDZkZmVLT2hRMTdUYlpGN0krR1NvUWNLMHNzTkdkbTc4ZTAycUsy?= =?utf-8?B?aTM4THB4Z3ZsTGQ2aTV3bGFyUncxZ2Jhd3doNEJKOTFDdGZGaGhaQmlQVmY4?= =?utf-8?B?YmUxeER3V2oyV0ZhSWtYOTIwRVBBVG8xV1lhVWFsWnFHamRXNU03ZHArWkhI?= =?utf-8?B?OXRLMDBoVSs3NktsVVVqLzhuamcwRmhQSytQaU9IcE90dlVLWFNxaHkxMVlG?= =?utf-8?B?MXNCQStKZlJkdzllcXkreHJ1RnA1VGMxNS9oT0VZdjFMeWRSMzF6dlFNV0Er?= =?utf-8?B?NlBYb3E2UFdkYzRBTjE3UlQ0WUQrZHkzci9MMUM3em9SbWd5QmRxMGxoV1hZ?= =?utf-8?B?dUZ4ajZhTWtHU2p1Yi8yMHU3YjdhcDZrZ21sWmJ0NFpZd0Y3U1AzZFl5RlM1?= =?utf-8?B?RlVGVXRGTFFWeE1YT2lXQ1VZUFpMdHBjWWMvSFlRQjNHcllzRGg5NE9YSXNZ?= =?utf-8?B?dSs5dkp5emdUcUR5aHowQXhIamNad25ucURjSG4xMFk0VWxhNzhNZGJCU3Q5?= =?utf-8?B?NFY3ZkE2Sm5GRDJHSjViZms2RVk0dHJQOEJFZVBYQTdlOUwvMUxBSmpsUGNL?= =?utf-8?B?LzdOV3ZxRmxxWFZITVpYc2RlbStGOUNDMzNPOHZrV1c3K2JLKzkyOTlEcGJK?= =?utf-8?B?djlGeFBHdkNqYSs3U2ZOL01ZZ09IYkVFcHBUd3h3Tmx2b2piRUowNm9INkZx?= =?utf-8?B?ODYvcStIOXB4bVRzWFQ3VkVIaExlWFJpRFNSM2tjdGx6c3Iyby9WOFZwQy9R?= =?utf-8?B?NzVtQjVMV21SV0NxRDFISmVoTHpjNkpCUjUwdm9McUVlRURBUDBnczIrTlBE?= =?utf-8?B?UGZBODE4Qkg3bHJTRVpJSlBQZGlZUTM0Sk1lM05ucXlwNlh2OEI1T09wYW0r?= =?utf-8?B?VVhlSU1rZDlJb0s5bkpHcFJ6bm5BYW1XV3ZvMlNmV3cxK2kzczllTXZaQzFh?= =?utf-8?B?bWdibzkzU1JDcEdCdWZlY2Fta2tFOTRUZzhrM1lLWlRXTm1ocy9DWFFrQ2xr?= =?utf-8?B?cG5ORzdIelgvS2c2ZE9Gbnk2TEVOM0dYV2ZlR1dUaFZBWFpJVGV2c2ErbHhv?= =?utf-8?B?MjJza3RYSXRCVTFRS3JjdGdTdmxNcFJDNCtzVUM1ZGNsdjQ2SElTbHgwRzAz?= =?utf-8?B?OHAwS0l2M3BNMGRoQXQyTjk0S0ZOTlZBNDJ1dUdneUlGc0tMMmdPakYrZ211?= =?utf-8?B?SFcrOUwrRTRXc2ZEY1BnU1RnbXRTa01ZcFpGd1FBZ3FZYnJCd29UUE1zYzAz?= =?utf-8?B?cnA0elpraFFZNVlRSW51OFdDYWgrejYzOTlOKy95c00vMlIyY2c0WUZjdk1a?= =?utf-8?B?cExqa2w2TG1uUG9YbVM4ZWkrU3ZQRDZjOXUvZzZCak5KUG1Yc1RkYzYxUlRk?= =?utf-8?B?ZHdpSGF2MXlGUUVUNmpiK09KTWRYRzVOdTI0ODFKNEFxZFRpRXh4L09kQ2VZ?= =?utf-8?B?T0JWUDdGRGE1bVhVUUZ3OXBnMTFZMmR4S3JSL2RranVQR3N0YThKYVY5VGM0?= =?utf-8?B?My92WVJUNFBVQXl5bDZyOUFJQktGblEyU2VNVWJXbkl4ZDVrSVB3enRIbnBo?= =?utf-8?B?Z2R6V0NsWjQzM1R4YWJxaHBzWHl5NVpXdHFWc2hRQ3R0TmZPMEtvaWRuRU5P?= =?utf-8?B?VzFaS1QrTUFWcUFtd0Q5NG5mTm5PQ1AzUGpJMlZOMzRWSWVXNVZGKzk2ZWVT?= =?utf-8?B?eWlXd0VLeG9VN1FmUmJaRFdxMUZqbXJNbldOVm44aTdUOERDWlBieHFBUjZU?= =?utf-8?B?c3pWZW5ibThMdVoyMzJ0Tnc0ZHF2MUxmdkp6ZURyQS9adG9wS0VsRzFKcEMw?= =?utf-8?B?N2NRZGszMGIwR3ltL2Q5eFEzQmJJMFB1YUtwTmtycmZ1TzZUb2dOSkxDQVFG?= =?utf-8?B?V2JUS0RRK0E2RXMxeTNnSGpnUlhkYllqeXhBQkNEQ05zL1Y2elJQZ0RteTVK?= =?utf-8?B?dTFISFBPcnduV0l6RnVTMWJMU3UzWWE3QzN4RlBoc0ZGbTdyWFErNXpGNjl0?= =?utf-8?B?Yis1blZCN2dLYk9PdmRuM1kvQUJ4L3JZdElSVlE5UTN6eSszWmRhZk95eStP?= =?utf-8?Q?Zcr2c8E2wgqHbRLQYn5JFYM=3D?= X-Microsoft-Antispam-Message-Info: fJ43j+V4sTby/PzSL82JTPj6ov5wWob63x1JUquDfVQ9hFKOvDTwUVPoSdvO3K9v+3Pz1boCQYmceVZW4KBoO//2GFpGarvnZVSwKAewHu5BQhNrLrTIE1lAnfK0ml96J1ChUTvx4geAeY9zT1lm5XKdSBqscsckjvCLNl6Hw8tlD2URsiIzaDGa8ePMzgoL50mt36UNAy8rWZzkXVYKMku+rHakPcBLIIIIA/ZYbsNQkWHdIsgANP1jV5SKFDANBSC0Ew2T2iwOC+//tG43/BCqCnm8fIbi+kE/Znpt95eAmMz8RjEmsMZpRk8lwccCD4UpT3/uyg+YEiId87pmqjoy9Zry0Ndidv6GZh9Avj4= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 6:SArQq99Dq3TxPRtLs7ZBDO0bt3uyBPM0nVNGY2jgMGzEhCyhATY5p4qLYiL1x+zuc7FnSPX/dcVB+2GPg3qJzZ3Cpf70+98rMAsooDbRpD+3SkBQGgehK33mUWQmMcqgFmPRdkn1EtPbFqAnOemZqBm4xm7RL1woOQ6sxDUe9k8Nuc8ZCKeNWOXpGvZthVAohGSVzEsqu7CHtVFzJw0fFuJdaeiL4x2lYCuydpZKhn/qW+78urkIyayG9qUj5RDbeGhkDt3OLwm368JhyzmuVY6/EZVqaIt3lUoUQ8D/X4CYSWRIs894qhhSn7ExPLIhVbHtUXKXKvlTPYDH+OeQtUUBTfDqSS/ktOokMwXmu7n6IzyLWjyAqJhVs+s9NwnSYJzIFJtNDwMiVLa7dSIyo4ce3wLzvFpHRHohHjcrDSg8nPX1ffeo89Y0XeIsBFTm8nwkIeTwFr4Tuv0dJzFetg==; 5:vGh9aR0KjjXuDqrJ/uzmVp6GaqOjGFuDKrCM2XLaxUT7y0H/9+f6SMRtG9a78OHwrRVo7DKue/uIrNR6khXLago8rMylhZcTfZyga13K5EXdpsuY3rGhhvHweBs/GhwsVkJQtjARImneq9FOGrhU4RaXUZXDS+XCbtC/x8wfOe0=; 7:sI44oI3XLKDV23ncvCqh8vPwJLJDinh+RHNfvzkbiCfdPR9sYrZh6XCdGe0CBq/7ecn4bxipz6j4c/41c3U5Xs5Rqow/7agljSvGS0NQvTvXGDfEjub7Go5CHbATM5saexpJEbmUMhi+er8pO+o6a611eV5ZflkEk99BCdSMB/K7T/ApnPDIYXZV5W2a1tq8dKIQLTaCkwmgm/HW9AgU2xPmeiNiZMaxopzPVavDzKcLQO2CSMgnE9KIk0szUJcj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 11:28:14.1064 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbf9344b-efdd-48f7-4db7-08d62d11242c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4910 Subject: Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 11:28:19 -0000 Hi Ferruh, On 08-10-2018 16:30, Ferruh Yigit wrote: > External Email > > On 10/8/2018 11:41 AM, Anoob Joseph wrote: >> This patchset fixes multiple issues reported by checkpatch in l2fwd >> code base. These issues would be flagged for any new copy of the file >> and hence, fixing at the source. >> >> Anoob Joseph (8): >> examples/l2fwd: remove quoted white space before newline >> examples/l2fwd: need space between two args >> examples/l2fwd: else should follow close brace >> examples/l2fwd: replace bare usage of 'unsigned' >> examples/l2fwd: follow convention for block comments >> examples/l2fwd: limit line to 80 char >> examples/l2fwd: space required between elements >> examples/l2fwd: remove null initialisation > Hi Anoob, > > I am not sure if it is good idea to get syntax only fixes, I would prefer to get > syntax fixes when some other code touches that area. I'm preparing a new copy of l2fwd with support for eventmode(as suggested in, https://mails.dpdk.org/archives/dev/2018-August/109717.html). All these issues were flagged when I did the copy. What would be the better approach in that case? Fix it in just the new application or fix the source? Fixing in just the new app would mean, the two versions will have a diff at the time of copy. And next time someone touches these lines, the same problem would be there. Thanks, Anoob