From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 68B3F1BE45 for ; Thu, 5 Jul 2018 10:17:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2018 01:17:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,311,1526367600"; d="scan'208";a="242785098" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 05 Jul 2018 01:17:27 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 5 Jul 2018 01:17:27 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 5 Jul 2018 01:17:26 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.100]) with mapi id 14.03.0319.002; Thu, 5 Jul 2018 16:17:25 +0800 From: "Zhao, MeijuanX" To: "Yigit, Ferruh" , Jerin Jacob , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Doherty, Declan" , Chas Williams , "Richardson, Bruce" , "Hunt, David" , "Van Haaren, Harry" , "Dumitrescu, Cristian" , "Ananyev, Konstantin" , "Horton, Remy" , "Ori Kam" , "De Lara Guarch, Pablo" , "Nicolau, Radu" , Akhil Goyal , "Kantecki, Tomasz" , "Burakov, Anatoly" , "Mcnamara, John" , "Li, Xiaoyun" , Thomas Monjalon , "Andrew Rybchenko" , "Han, YingyaX" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Ma, Liang J" , Xueming Li , Pavan Nikhilesh , "Zhao, MeijuanX" Thread-Topic: [dpdk-dev] [PATCH v6] examples: fix RSS hash function configuration Thread-Index: AQHUE8mt0ROVd4Xi9k+MvVpO8Jn3x6SASPoQ Date: Thu, 5 Jul 2018 08:17:23 +0000 Message-ID: <9866F1E5CE768A45B24F6603C6EF54DE013BCF0C@shsmsx102.ccr.corp.intel.com> References: <20180703180820.7462-1-ferruh.yigit@intel.com> <20180704200222.60945-1-ferruh.yigit@intel.com> In-Reply-To: <20180704200222.60945-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] examples: fix RSS hash function configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 08:17:29 -0000 -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit Sent: Thursday, July 5, 2018 4:02 AM To: Jerin Jacob ; Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard ; Doherty, Declan ; Chas Wi= lliams ; Richardson, Bruce ; Hun= t, David ; Van Haaren, Harry ; Dumitrescu, Cristian ; Ananyev, Konsta= ntin ; Horton, Remy ; = Ori Kam ; De Lara Guarch, Pablo ; Nicolau, Radu ; Akhil Goyal ; Kantecki, Tomasz ; Burakov, Anatoly <= anatoly.burakov@intel.com>; Mcnamara, John ; Li, X= iaoyun ; Thomas Monjalon ; Andre= w Rybchenko Cc: dev@dpdk.org; Yigit, Ferruh ; Ma, Liang J ; Xueming Li ; Pavan Nikhilesh Subject: [dpdk-dev] [PATCH v6] examples: fix RSS hash function configuratio= n ethdev layer introduced checks for application requested RSS hash functions= and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS has= h functions without checking underlying hardware support. Updated examples to mask out unsupported RSS has functions during device co= nfiguration. Prints a log if configuration values updated by this check. Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again") Signed-off-by: Ferruh Yigit Tested-by: Zhao meijuan< meijuanx.zhao@intel.com >;Han yingya< yingyax.han@= intel.com >