* [dpdk-dev] [PATCH] cmdline: avoid garbage in unused fields of parsed result
@ 2018-01-20 3:26 Xueming Li
2018-01-22 13:14 ` Olivier Matz
0 siblings, 1 reply; 3+ messages in thread
From: Xueming Li @ 2018-01-20 3:26 UTC (permalink / raw)
To: Olivier MATZ; +Cc: Xueming Li, dev, Adrien Mazarguil, stable
The result buffer was not initialized before parsing, inducing garbage
in unused fields or padding of the parsed structure.
Initialize the result buffer each time before parsing.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
lib/librte_cmdline/cmdline_parse.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c
index c74b146fc..7f799f94d 100644
--- a/lib/librte_cmdline/cmdline_parse.c
+++ b/lib/librte_cmdline/cmdline_parse.c
@@ -168,6 +168,8 @@ match_inst(cmdline_parse_inst_t *inst, const char *buf,
int n = 0;
struct cmdline_token_hdr token_hdr;
+ if (resbuf != NULL)
+ memset(resbuf, 0, resbuf_size);
/* check if we match all tokens of inst */
while (!nb_match_token || i < nb_match_token) {
token_p = get_token(inst, i);
--
2.13.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] cmdline: avoid garbage in unused fields of parsed result
2018-01-20 3:26 [dpdk-dev] [PATCH] cmdline: avoid garbage in unused fields of parsed result Xueming Li
@ 2018-01-22 13:14 ` Olivier Matz
2018-01-25 22:17 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2018-01-22 13:14 UTC (permalink / raw)
To: Xueming Li; +Cc: dev, Adrien Mazarguil, stable
On Sat, Jan 20, 2018 at 11:26:31AM +0800, Xueming Li wrote:
> The result buffer was not initialized before parsing, inducing garbage
> in unused fields or padding of the parsed structure.
>
> Initialize the result buffer each time before parsing.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] cmdline: avoid garbage in unused fields of parsed result
2018-01-22 13:14 ` Olivier Matz
@ 2018-01-25 22:17 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-01-25 22:17 UTC (permalink / raw)
To: Xueming Li; +Cc: stable, Olivier Matz, dev, Adrien Mazarguil
22/01/2018 14:14, Olivier Matz:
> On Sat, Jan 20, 2018 at 11:26:31AM +0800, Xueming Li wrote:
> > The result buffer was not initialized before parsing, inducing garbage
> > in unused fields or padding of the parsed structure.
> >
> > Initialize the result buffer each time before parsing.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-25 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-20 3:26 [dpdk-dev] [PATCH] cmdline: avoid garbage in unused fields of parsed result Xueming Li
2018-01-22 13:14 ` Olivier Matz
2018-01-25 22:17 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).