From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dongdong Liu <liudongdong3@huawei.com>,
dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru
Cc: stable@dpdk.org, yisen.zhuang@huawei.com, lihuisong@huawei.com
Subject: Re: [PATCH 01/16] net/hns3: fix possible truncation of hash key when config
Date: Fri, 10 Mar 2023 19:36:25 +0000 [thread overview]
Message-ID: <987538c3-9269-aeaf-58c3-879dd23abbe2@amd.com> (raw)
In-Reply-To: <20230310093518.5198-2-liudongdong3@huawei.com>
On 3/10/2023 9:35 AM, Dongdong Liu wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> The hash key length of hns3 driver is obtained from firmware. If the
> length isn't a multiple of HNS3_RSS_HASH_KEY_NUM (16), the last part
> of hash key will be truncated.
>
I am not sure if the explanation is correct, according below code last
part of the key is truncated if key_len *is* multiple of
HNS3_RSS_HASH_KEY_NUM.
Because code assumes "key_len % HNS3_RSS_HASH_KEY_NUM" will give the
remaining part of the key, but when key_len is multiple of
HNS3_RSS_HASH_KEY_NUM it gives 0, causing last HNS3_RSS_HASH_KEY_NUM
chunk truncated.
If above understanding correct, I can fix commit log while merging.
> Fixes: 4a7384e3c34d ("net/hns3: refactor set RSS hash algorithm and key interface")
> Fixes: c37ca66f2b27 ("net/hns3: support RSS")
> Cc: stable@dpdk.org
>
I am not sure if `c37ca66f2b27 ("net/hns3: support RSS")` is needed
here, issue seems because of commit 4a7384e3c34d, so this should be:
Fixes: 4a7384e3c34d ("net/hns3: refactor set RSS hash algorithm and key
interface")
Cc: stable@dpdk.org
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> ---
> drivers/net/hns3/hns3_rss.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c
> index d6e0754273..2011c18b9b 100644
> --- a/drivers/net/hns3/hns3_rss.c
> +++ b/drivers/net/hns3/hns3_rss.c
> @@ -301,7 +301,8 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,
> req->hash_config |= (hash_algo & HNS3_RSS_HASH_ALGO_MASK);
> req->hash_config |= (idx << HNS3_RSS_HASH_KEY_OFFSET_B);
>
> - if (idx == max_bd_num - 1)
> + if (idx == max_bd_num - 1 &&
> + (key_len % HNS3_RSS_HASH_KEY_NUM) != 0)
> cur_key_size = key_len % HNS3_RSS_HASH_KEY_NUM;
> else
> cur_key_size = HNS3_RSS_HASH_KEY_NUM;
next prev parent reply other threads:[~2023-03-10 19:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 9:35 [PATCH 00/16] net/hns3: some code refactor for hns3 RSS Dongdong Liu
2023-03-10 9:35 ` [PATCH 01/16] net/hns3: fix possible truncation of hash key when config Dongdong Liu
2023-03-10 19:36 ` Ferruh Yigit [this message]
2023-03-29 1:56 ` lihuisong (C)
2023-03-10 9:35 ` [PATCH 02/16] net/hns3: fix possible truncation of redirection table Dongdong Liu
2023-03-10 19:36 ` Ferruh Yigit
2023-03-10 9:35 ` [PATCH 03/16] net/hns3: use hardware config to report hash key Dongdong Liu
2023-03-10 9:35 ` [PATCH 04/16] net/hns3: use hardware config to report hash types Dongdong Liu
2023-03-10 9:35 ` [PATCH 05/16] net/hns3: use hardware config to report redirection table Dongdong Liu
2023-03-10 9:35 ` [PATCH 06/16] net/hns3: separate the setting of hash algorithm Dongdong Liu
2023-03-10 19:36 ` Ferruh Yigit
2023-03-29 1:58 ` lihuisong (C)
2023-03-29 8:13 ` Ferruh Yigit
2023-03-10 9:35 ` [PATCH 07/16] net/hns3: separate the setting of hash key Dongdong Liu
2023-03-10 9:35 ` [PATCH 08/16] net/hns3: separate the setting of redirection table Dongdong Liu
2023-03-10 9:35 ` [PATCH 09/16] net/hns3: separate the setting of RSS types Dongdong Liu
2023-03-10 9:35 ` [PATCH 10/16] net/hns3: separate the setting and clearing of RSS rule Dongdong Liu
2023-03-10 9:35 ` [PATCH 11/16] net/hns3: use new RSS rule to configure hardware Dongdong Liu
2023-03-10 9:35 ` [PATCH 12/16] net/hns3: save hash algo to RSS filter list node Dongdong Liu
2023-03-10 9:35 ` [PATCH 13/16] net/hns3: adding queue buffer size hash rule allowed Dongdong Liu
2023-03-10 9:35 ` [PATCH 14/16] net/hns3: separate rte flow RSS config from hns3 rss conf Dongdong Liu
2023-03-10 9:35 ` [PATCH 15/16] net/hns3: reimplement hash flow function Dongdong Liu
2023-03-10 9:35 ` [PATCH 16/16] net/hns3: add the verification of RSS types Dongdong Liu
2023-03-10 20:58 ` [PATCH 00/16] net/hns3: some code refactor for hns3 RSS Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987538c3-9269-aeaf-58c3-879dd23abbe2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).