From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6CD241E2E; Fri, 10 Mar 2023 20:36:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B952741143; Fri, 10 Mar 2023 20:36:39 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by mails.dpdk.org (Postfix) with ESMTP id ED1F340A8B; Fri, 10 Mar 2023 20:36:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bvBnolAGResCsaPkYNhXmE/w0cKW3BXw1vrXdTZTVeZn6cpRh+kOEX5etDDXBF3pd0kxJjjC1Ssw54gPuYorxCGM/qKyf9TScIqboFgO6xbHY48/puaht4jJCODl2z3e/ADsy+4Bowq9WiWgf/PzoCcSc4jqEvlk0M/RVE1f/A9lp5ZdVPhcsn7sVBSr+P4O+rmLmemBJU6U4IOKvdBunAdGYuzvmwoXZtUjYniUPJq7cDAlBFY/ttx00NvN4pTXHzMudG4htG7cKzuH/BYl1S5fvAKwc4QMAzPWUbCi37kAPbJKHFrvKziNY0a2wkQ6GktpYMEicLEKZ8b7o91Khw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CLIHpVSw9S0CUfcdcPr2Q2BVdwcgqQ6rY16XUx6D5gE=; b=dwheiXVwIfxfySAGwZsMfaCEOvSx1MfQYjy63kXaPOUbjCs6tgewSbH4gKGM19nLTD4IfCrAKUxhyyOizmTrMIl4IBFL376gk+dQbILoSB5civ1DCZSl6QXr/fX5ECvoP8zInh7BbaCJn7cgeBUFeCxKHn9p/BpHgfhVWVqPMtj0OgeZKfGzLYa9g/FEWRL0R/gZAlIRkePG2sohIUT8OjhOk4V8Y3EvzsUOHwNq4dCb9DxyATh6gZ9bN+OYlxrxpzFGmMgDpzWzM0xQwud3o+SbqGAccfzRf5l9b6n9k5HgwT2Hx3g7myclifoqeIRdq5Xccfcv7zDqEgvb/paFiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CLIHpVSw9S0CUfcdcPr2Q2BVdwcgqQ6rY16XUx6D5gE=; b=CayrXS1FoqgkTpwXAte6jqTFVCLCJo9zfTmMu+ervIa401aJ8bZEh7WGmSXB8zm8gg6feivr7DZyCkm2Xjj34JTtv+TpxXye9mwVGXw9kcRs0oTT7P1Dag0BpydkpjePMb8fgXyQJ9CNs7cNIybIsBwdGm7OGydlG83U0VKmfuo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB8214.namprd12.prod.outlook.com (2603:10b6:930:76::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 19:36:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 19:36:33 +0000 Message-ID: <987538c3-9269-aeaf-58c3-879dd23abbe2@amd.com> Date: Fri, 10 Mar 2023 19:36:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Dongdong Liu , dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Cc: stable@dpdk.org, yisen.zhuang@huawei.com, lihuisong@huawei.com References: <20230310093518.5198-1-liudongdong3@huawei.com> <20230310093518.5198-2-liudongdong3@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH 01/16] net/hns3: fix possible truncation of hash key when config In-Reply-To: <20230310093518.5198-2-liudongdong3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0321.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::21) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB8214:EE_ X-MS-Office365-Filtering-Correlation-Id: d37a8f92-316a-4f82-97cc-08db219ec0c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qvu11BhQjkQz4N8v9GCE5wn0WbNEstrTip6eK06LM/3qCe4jrKcN/RM2aQhTF831WAGZGaEc08vpZ1LqBLsaaAqG24GFSYBQq52EMTiFOedMr6hkRyyBHeL3UBrGbkcWgwsLz2E7UylUpgEpgpzgvpFox37ifc5U2wUPHM8rt8dAqjLc6UlENxfcZg/5c5/Z01/I0JfLbRJEKTiJkxMpKiFPTo+rTLzu+yVNwbxkeVunyITbC8dMl2JqV4J6ExI9nJFm15Czw+rXl4Fiz3bV82Zntq4bURmOxRywK4hAqkt+WSRMvvzeXmY0X/sAz/y+zXJ+vnN2tFo2rEtZOYKPUYAGFTsL02YbgT1CjqcPUpvoypA97St1b5VCsCoVJTCKfjptwaupZVgRym/Jb0GaIpn8K7xUZVqnJR24ca5S1Kex98lBwKRQnnbWQm7Kok8GAT0wRLlXO0urKsSbBgjLkC50JE6c3x2CcBQcyA97O1iz7ycfYiDH8xccEG7QX5Mr1ogO2yhFUTgryBFZLxdXrTd2imC1JgTkaQNMONvuManU6qrVtplI4hZG4qIqnUnegVskxyE97wtHIM1AVdi82h7YhEpPkXU4onGUS2rbsvD1NKnHxduB47UZE0S3RApCKa2yWzKqDCkcPcetxmof5dk8c2moBEqZfrXSENPMQRslH3lrw0Rw/p4bHUXQ6xnQHghFrynavPbhesbSXZUCfbbapDZgXzV+lSNPU0Hdnho= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199018)(31686004)(66946007)(44832011)(2906002)(5660300002)(26005)(8676002)(36756003)(8936002)(4326008)(66556008)(66476007)(31696002)(316002)(86362001)(478600001)(6486002)(53546011)(38100700002)(6666004)(6512007)(41300700001)(6506007)(2616005)(186003)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXlSZkJqM3ZzWFJteDdZSnh3a2VZeUJVUDVYMjFEWXI4TmlyQ2NScTNNa1F5?= =?utf-8?B?dW5KcFp4WU40dFlaUEU0aVdhMWhNRWlaRDhFdmxTSG4zVHFwb1ExOHpyZlZH?= =?utf-8?B?eWk5eU9NeHpTVVEzMGp2bFdlTlFCSFByektXc2UwUWVyL3p3V1M0TEczOG9r?= =?utf-8?B?OXFZWURzem9iQUhRaDhsQlRtWTN5N0VUNk02RFNTQzVhNkRwbEExY3BUdTVC?= =?utf-8?B?N25Vc2dxb1pIRVZWbmowT3JNakhNQXM2T2NLeUFPbVhCTE5GdTROZTROYTBy?= =?utf-8?B?TjQvVDJQRFQvUzRCSitFamloaFhVZXpYVDlUdzdFM0dXMXkxNEN4WG5VeHF0?= =?utf-8?B?VmdBOXVLdHpSZ3JQQmR4dmo5OHNFRTRVQnZZS082V2pxM2d1TEQxZ1IyU1dj?= =?utf-8?B?T1B5VndNNnBLZWdENmx5T2FOMTJEN3RiTGVsaDZEVnVpNWRZeE43RWpXM3R0?= =?utf-8?B?endLSjdRU1lqd1JKcWFJTUpoYTg0WEFYcVZJdGMvaUQxR0ZOZ3RTbFEzYjVV?= =?utf-8?B?dlphR2wwMnk1bVdiaVlUbW1BbFNmMHZMWEc2clh4ZFFkTWpHczBPYktFSFNW?= =?utf-8?B?clBFMEg3WHpZLzdObExYUkJOQ0owSWJzWEJNSElFcDdXbngrVzd5UmYzS2Q2?= =?utf-8?B?bWZmMmRiOEdFQU9UcEd4RXV6cTF2WEhPZGdKRU03RFFlYW94a010TSt1UDF1?= =?utf-8?B?SGtWeXhPTG9kU0ttdnFMbHcwVkJpWWs5Zk9oeXRuUWdzbU0yUHQyY09tWlMv?= =?utf-8?B?MTFLMlEzc2plTkl3NXhPdUgwbHZBVC96Zm1IUHBNeXlGd0wvUmQvQnh4ajBM?= =?utf-8?B?U01MRXpZWTcraURacC9CbHZrdHlJNUhVZzVLU0ROWGhmSmtQS0hrNUlxTml5?= =?utf-8?B?SVMvbEhjZWlRNlJDR3lIeGlVWGRBSHpRL1JhdGREa0lra0w1b1hvM1kwVzRp?= =?utf-8?B?bEh6RTBldnM4QzE0ZGhXOWtZdDhyckRndE5laUtNaFhQbVdpZmRzLzVvaU1n?= =?utf-8?B?OGJtaG9Xd2lIT3FNMHRUeEtVdEttNWU2UDMyVXp0a3pvSzd6RUxyQ25jYm9v?= =?utf-8?B?SE4zUndDYjNoNXBWMTlucFJMWnY2TUxTMTlLSmZ3RlF1UGY4VXRHYnI2SG5F?= =?utf-8?B?QkZkNnhrNlhWNFhTM1JGckhLNmZjeXgxYWFPR2ZaakpiOGFhb3lRMzVqc256?= =?utf-8?B?eUIwaS9wa3huSHY0SW9QMkpvQjk4b056OU9OY29FOTRqNFhqazcwYWE4L091?= =?utf-8?B?WGtKMWVsQVdvNVVJTngzMHdObStLVFZLOHF0cGpWcUNONGlNWjlNQ3RkR1lw?= =?utf-8?B?dTg0Qm5wbEtqcmRiZTlzT0NFMXQzZHlzNFNBVElTeGNOemg5VE9WQU1TVFRy?= =?utf-8?B?Z0RQMUo2alZadGFqR2VTZHhGS1QrL01kU25CNzluVFpRbExVSWJjS3NodE13?= =?utf-8?B?RmQvT2x6R2RuZG01RWhxTUFQY1ZMTkZRM1FBZzRKVVpaUUpRSEduY0xNUmsr?= =?utf-8?B?V2YxbjJDSGFweTF0dWlPZ29TeDB3dVh2RXRaZ1ExZ3krMVNpOHRMSlJOVXZZ?= =?utf-8?B?dmtDSHUwOTY0UU9Sd1hrTXF3eDhyTThzQXZkVDNZbE56am9VZi9PUGxxMGVj?= =?utf-8?B?dkREdGJ6SFFBUDE1a05FaC9kYVBHdEYwbnBhbmpTUFQ1RmpHWjEzQkVVbG1J?= =?utf-8?B?dUlhNG5GTHRYaDRHdmlVa3Z1V3g2RThRd2ZJVXJ1SVRRVlVnaXdvY2dwL0RD?= =?utf-8?B?RloxZ2ttOWRGdDI4V0U2b1ZTMkFxQmZIWXpZcVBwS3NIZCs0amgxYTB6YlV4?= =?utf-8?B?YmU0dmUrcm5zZDFhV3ZWcGhpdWtZMTVoM2pSUDJUVWZoNUVpQWF6Tm1tZWsv?= =?utf-8?B?NzJqc2RvOC9rdzlWaXRVeVBQclUwdnJOam53YVhIUmhBcGpZMVk3WGR1MjBq?= =?utf-8?B?YWo1RTdlZVk3a0JxRmhkYjcvL2ZiMDFaYzVoTlB2V1UxaXhZaThJbzFRSmZm?= =?utf-8?B?cXZORXJmblRndG04R0w0TU5nZ2FzSVIxVjk3UkZHR3Y3dStHTlNKNGhXcFJJ?= =?utf-8?B?NXNmQXJNdkVNckRraXBEYlRjSU14U3ZCN0s3MDVmMTZOQmlmVnN1TjZCVk5m?= =?utf-8?Q?x69uUgD/qtwIialTUAy1OSPqi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d37a8f92-316a-4f82-97cc-08db219ec0c2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 19:36:33.1208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g3iTbVSTY5e4LbzMyYf+HBFjojCcuUfIPraLknWAnJzajFp8A8ZYGkMWJ2BqdX1Y X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8214 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2023 9:35 AM, Dongdong Liu wrote: > From: Huisong Li > > The hash key length of hns3 driver is obtained from firmware. If the > length isn't a multiple of HNS3_RSS_HASH_KEY_NUM (16), the last part > of hash key will be truncated. > I am not sure if the explanation is correct, according below code last part of the key is truncated if key_len *is* multiple of HNS3_RSS_HASH_KEY_NUM. Because code assumes "key_len % HNS3_RSS_HASH_KEY_NUM" will give the remaining part of the key, but when key_len is multiple of HNS3_RSS_HASH_KEY_NUM it gives 0, causing last HNS3_RSS_HASH_KEY_NUM chunk truncated. If above understanding correct, I can fix commit log while merging. > Fixes: 4a7384e3c34d ("net/hns3: refactor set RSS hash algorithm and key interface") > Fixes: c37ca66f2b27 ("net/hns3: support RSS") > Cc: stable@dpdk.org > I am not sure if `c37ca66f2b27 ("net/hns3: support RSS")` is needed here, issue seems because of commit 4a7384e3c34d, so this should be: Fixes: 4a7384e3c34d ("net/hns3: refactor set RSS hash algorithm and key interface") Cc: stable@dpdk.org > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu > --- > drivers/net/hns3/hns3_rss.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c > index d6e0754273..2011c18b9b 100644 > --- a/drivers/net/hns3/hns3_rss.c > +++ b/drivers/net/hns3/hns3_rss.c > @@ -301,7 +301,8 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo, > req->hash_config |= (hash_algo & HNS3_RSS_HASH_ALGO_MASK); > req->hash_config |= (idx << HNS3_RSS_HASH_KEY_OFFSET_B); > > - if (idx == max_bd_num - 1) > + if (idx == max_bd_num - 1 && > + (key_len % HNS3_RSS_HASH_KEY_NUM) != 0) > cur_key_size = key_len % HNS3_RSS_HASH_KEY_NUM; > else > cur_key_size = HNS3_RSS_HASH_KEY_NUM;