From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E9D14A0471 for ; Mon, 17 Jun 2019 13:35:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E0BA1BF00; Mon, 17 Jun 2019 13:35:42 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BAE901BEED; Mon, 17 Jun 2019 13:35:40 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4B7A64C006C; Mon, 17 Jun 2019 11:35:39 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Jun 2019 12:35:29 +0100 To: Tiwei Bie CC: Maxime Coquelin , Zhihong Wang , , Dilshod Urazov , References: <1559587805-1637-1-git-send-email-arybchenko@solarflare.com> <1560680229-8166-1-git-send-email-arybchenko@solarflare.com> <1560680229-8166-2-git-send-email-arybchenko@solarflare.com> <20190617085426.GC17273@___> From: Andrew Rybchenko Message-ID: <987aa54f-c288-6983-6886-cd9d8568c6aa@solarflare.com> Date: Mon, 17 Jun 2019 14:35:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190617085426.GC17273@___> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24684.003 X-TM-AS-Result: No-7.653400-8.000000-10 X-TMASE-MatchedRID: wQVy7q402w3mLzc6AOD8DfHkpkyUphL9LgJt/p5N7ykqNkQs1tMxxxFl wJhVcSVOuJcOsGPcBgiNbKptqmmUncuRBwUhxclNfid4LSHtIAMmKH/Kj46+VX9nRLJB1yYQuT0 57P1zdgWjjGu/2S799ZGTpe1iiCJq71zr0FZRMbDQLWxBF9DMQcRB0bsfrpPIx1FPlNAAmcDDdf epE+aNvJCVPIzthUqABa8zhfxYruY4MoTM5IePaZ6oP1a0mRIj X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.653400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24684.003 X-MDID: 1560771340-G5jaVUatg-A7 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: move VLAN tag insertion to Tx prepare X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/17/19 11:54 AM, Tiwei Bie wrote: > On Sun, Jun 16, 2019 at 11:17:09AM +0100, Andrew Rybchenko wrote: >> From: Dilshod Urazov >> >> VLAN tag insertion should be in Tx prepare, not in Tx burst functions. > Please add some details in the commit log. Done, please, see v4. Also, please, note that the following patch [1] fixes the problem with Tx checksum offload after VLAN insertion. Andrew. [1] https://patches.dpdk.org/patch/54830/