From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A4D65A0A0E;
	Wed,  3 Feb 2021 00:27:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2F3C42403EF;
	Wed,  3 Feb 2021 00:27:04 +0100 (CET)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by mails.dpdk.org (Postfix) with ESMTP id 692292403E9
 for <dev@dpdk.org>; Wed,  3 Feb 2021 00:27:02 +0100 (CET)
IronPort-SDR: 2Ws5H0J1mowh6jK2MrVJwqSQEnLfxSFh/6SZO9OeUw4cgkBgri4kj0cjNkAnC47YRcZIJiuBQ7
 iS9sW4qDEMlg==
X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="181096715"
X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="181096715"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Feb 2021 15:27:01 -0800
IronPort-SDR: I5lHIRU3OerraCLjRbgeUrHYMe91YaplVoEd2THW0ViAg5Qb3MuI0OT08L1TtYJBDwoisUle8F
 3UjKX2C7Iu0Q==
X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391939475"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112])
 ([10.213.226.112])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Feb 2021 15:26:59 -0800
To: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
References: <20210201203138.87301-1-maxime.coquelin@redhat.com>
 <CAJFAV8xJzF6vLyAEjFg5i4ms3ByfsGY3-Qt5UAKWXcJuSET2nA@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, Wei Ling <weix.ling@intel.com>
Message-ID: <988aeb1a-dbba-7612-0045-86345402385e@intel.com>
Date: Tue, 2 Feb 2021 23:26:58 +0000
MIME-Version: 1.0
In-Reply-To: <CAJFAV8xJzF6vLyAEjFg5i4ms3ByfsGY3-Qt5UAKWXcJuSET2nA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/2/2021 10:03 AM, David Marchand wrote:
> On Mon, Feb 1, 2021 at 9:33 PM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> VIRTIO_OPS() macro relies on the port ID stored in the
>> virtio_hw struct. Issue is that it is used before being
>> assigned at init time. It results in all devices setting
>> ops on port ID 0, causing crash later when calling ops
>> for port IDs other than 0.
>>
>> This patch ensures port ID assignment is done at early
>> primary process probe time, before it is being used.
>>
>> Bugzilla ID: 631
>> Fixes: 512e27eeb743 ("net/virtio: move PCI specific dev init to PCI ethdev init")
>>
>> Reported-by: Wei Ling <weix.ling@intel.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> Tested-by: Wei Ling <weix.ling@intel.com>
 >

Applied to dpdk-next-net/main, thanks.