From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E684A2C6E for ; Mon, 3 Apr 2017 12:02:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491213743; x=1522749743; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=JGmjdy3lPzcZjoRnQBv7VCUOt5Xk+TZYPxCsK/dnEgU=; b=EnIV5wRBX1AigZREE31D1BD+s4JqMhp7aSMw+QmvDzI2UqqxYOGRtmx9 myH0d2tmpzsQ0rcQkrkxdUW3J+HCzQ==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2017 03:02:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,269,1486454400"; d="scan'208";a="1150188674" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga002.fm.intel.com with ESMTP; 03 Apr 2017 03:02:19 -0700 To: "Lu, Wenzhuo" , "Zhang, Helin" , Thomas Monjalon , Yongseok Koh , "Ananyev, Konstantin" References: <20170316224056.19685-1-yskoh@mellanox.com> <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com> <1920337.9E3jvcbJyk@xps13> <6A0DE07E22DDAD4C9103DF62FEBC09093B58649D@shsmsx102.ccr.corp.intel.com> Cc: "dev@dpdk.org" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" From: Ferruh Yigit Message-ID: <9894d012-a63c-9f5c-b98c-877ec304a817@intel.com> Date: Mon, 3 Apr 2017 11:02:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B58649D@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 10:02:23 -0000 On 4/1/2017 8:28 AM, Lu, Wenzhuo wrote: > Hi, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin <...> >>> -----Original Message----- >>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] <...> >>> 2017-03-20 16:04, Yongseok Koh: >>>> In rte_eth_check_reta_mask(), it is required to align the size of >>>> the RETA table to RTE_RETA_GROUP_SIZE but as the size can be less >>>> than the limit, this should be removed. The change is also applied >>>> to a command of >>> testpmd. >>>> >>>> Signed-off-by: Yongseok Koh <...> >>> There is no comment for this constraint neither in the code nor in the >>> commit: http://dpdk.org/commit/66c594904 So, I guess it can be removed. >>> If a check is needed, it could be added in the relevant drivers. >>> >>> Helin, Konstantin, please check for Intel drivers. >> Hi Thomas >> >> Thank you very much for the reminder! >> We will check that and see if there is any impacts to Intel drivers. > I don't think it has any impact to the drivers. > To my opinion, it's a good fix as it makes the name ' reta_size' more reasonable. Series applied to dpdk-next-net/master, thanks.