From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
Date: Mon, 24 Jun 2019 11:25:07 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B4296E@smartserver.smartshare.dk> (raw)
In-Reply-To: <20190619182217.8482-1-stephen@networkplumber.org>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
>
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
>
> Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/bnx2x/bnx2x_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
> b/drivers/net/bnx2x/bnx2x_ethdev.c
> index 45c6c363c077..0ee35e4e4d8e 100644
> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> @@ -150,7 +150,6 @@ static void bnx2x_periodic_start(void *param)
> if (ret) {
> PMD_DRV_LOG(ERR, sc, "Unable to start periodic"
> " timer rc %d", ret);
> - assert(false && "Unable to start periodic timer");
> }
> }
> }
> --
> 2.20.1
>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2019-06-24 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 18:22 Stephen Hemminger
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
2019-06-24 9:23 ` Morten Brørup
2019-06-24 9:24 ` Morten Brørup
2019-06-19 22:56 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: " Rasesh Mody
2019-06-24 9:25 ` Morten Brørup [this message]
2019-06-24 11:31 ` Ferruh Yigit
2019-06-24 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35B4296E@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).