From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Anatoly Burakov" <anatoly.burakov@intel.com>
Cc: "Olivier Matz" <olivier.matz@6wind.com>,
"Andrew Rybchenko" <arybchenko@solarflare.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] The type string in the malloc library is unused
Date: Sat, 14 Sep 2019 10:29:34 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B42A9B@smartserver.smartshare.dk> (raw)
In-Reply-To: <CAOaVG17_bhBOfJdvHZOzoVO3t7CXCZCa7f=_Q=_Pi5jgnY3GzA@mail.gmail.com>
I tend to agree with Stephen here, although it will break the API/ABI.
Another argument supporting its removal is the fact that it has remained non-implemented for many years, so a function for dumping information about rte_malloc'ed memory using the "type" string for debugging purposes has apparently not been in very high demand.
Med venlig hilsen / kind regards
- Morten Brørup
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
Sent: Saturday, September 14, 2019 8:24 AM
To: Morten Brørup
Subject: Re: [dpdk-dev] The type string in the malloc library is unused
I would vote for removing it.
It is too late to implement it without breaking existing code.
On Fri, Sep 13, 2019, 3:32 PM Morten Brørup <mb@smartsharesystems.com> wrote:
Hi Anatoly,
The functions in the DPDK malloc library takes a "type" parameter (a string, supposedly for debug purposes), but the underlying malloc_heap functions (which take the same string parameter) don't store or use this string for anything.
Is the intention to implement this sometime in the future, or should it be considered for removal?
prev parent reply other threads:[~2019-09-14 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 13:32 Morten Brørup
2019-09-13 19:38 ` Alexander Pshenichnikov
2019-09-14 7:06 ` Morten Brørup
[not found] ` <CAOaVG17_bhBOfJdvHZOzoVO3t7CXCZCa7f=_Q=_Pi5jgnY3GzA@mail.gmail.com>
2019-09-14 8:29 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35B42A9B@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).