From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Jerin Jacob" <jerinjacobk@gmail.com>, "Gavin Hu" <Gavin.Hu@arm.com>
Cc: <jerinj@marvell.com>, <dev@dpdk.org>, <thomas@monjalon.net>,
<olivier.matz@6wind.com>, <arybchenko@solarflare.com>,
<bruce.richardson@intel.com>, <konstantin.ananyev@intel.com>,
<hemant.agrawal@nxp.com>, <shahafs@mellanox.com>,
"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
<viktorin@rehivetech.com>, <drc@linux.vnet.ibm.com>,
<anatoly.burakov@intel.com>, <stable@dpdk.org>,
"Jerry Hao" <chao@amperecomputing.com>, "nd" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for nonx86
Date: Fri, 20 Dec 2019 11:54:47 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C60C90@smartserver.smartshare.dk> (raw)
In-Reply-To: <CALBAE1P04FT6TW+OnCwbxMkCAahZU5_6dEm8ymaRFKVSqqmf=g@mail.gmail.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Friday, December 20, 2019 4:45 AM
>
> On Fri, Dec 20, 2019 at 8:56 AM Gavin Hu <Gavin.Hu@arm.com> wrote:
> >
> > Hi Jerin,
> >
> > It got two coding style warnings, otherwise,
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>
> Thanks Gavin for review. Since the existing code is using "unsigned"
> in that file, I thought of not change by this patch.
> If someone thinks, It is better to change then I can send v2 by fixing
> "unsigned" to "unsigned int" across the file as a first patch in the
> series.
>
The use of the type "unsigned" is a general issue with older DPDK libraries. Anyone touching any of these libraries will get these warnings. They should all be fixed. I'm not saying you should do it; I'm only suggesting that someone should create a dedicated patch to fix them all.
> >
> > WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of
> 'unsigned'
> > #144: FILE: lib/librte_mempool/rte_mempool.c:84:
> > +arch_mem_object_align(unsigned obj_size)
> >
> > WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of
> 'unsigned'
> > #154: FILE: lib/librte_mempool/rte_mempool.c:106:
> > +arch_mem_object_align(unsigned obj_size)
next prev parent reply other threads:[~2019-12-20 10:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:42 [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86 jerinj
2019-12-20 3:26 ` Gavin Hu
2019-12-20 3:45 ` Jerin Jacob
2019-12-20 10:54 ` Morten Brørup [this message]
2019-12-20 15:55 ` Honnappa Nagarahalli
2019-12-20 16:55 ` Jerin Jacob
2019-12-20 21:07 ` Honnappa Nagarahalli
2019-12-21 5:06 ` Jerin Jacob
2019-12-27 15:54 ` Olivier Matz
2020-01-11 13:34 ` [dpdk-dev] [PATCH v2] " jerinj
2020-01-11 17:41 ` Stephen Hemminger
2020-01-13 6:49 ` [dpdk-dev] [PATCH v3] " jerinj
2020-01-13 9:46 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-01-13 11:46 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-01-14 21:06 ` [dpdk-dev] [PATCH v4] mempool: remove memory wastage on " jerinj
2020-01-16 13:10 ` Jerin Jacob
2020-01-20 12:24 ` Olivier Matz
2020-01-20 12:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35C60C90@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=chao@amperecomputing.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).