DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>,
	"dev" <dev@dpdk.org>, "Aaron Conole" <aconole@redhat.com>
Cc: "Olivier Matz" <olivier.matz@6wind.com>,
	"Andrew Rybchenko" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores >RTE_MAX_LCORE
Date: Tue, 14 Jan 2020 16:32:40 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C60CE1@smartserver.smartshare.dk> (raw)
In-Reply-To: <CAJFAV8wkweaLbna5-VU_EZT9-nP-253neE4M5JPLRF97AAscYw@mail.gmail.com>

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> Sent: Tuesday, January 14, 2020 1:59 PM
> 
> On Mon, Dec 2, 2019 at 4:36 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > We are currently stuck with no option but recompile a DPDK if the
> system
> > has more cores than RTE_MAX_LCORE.
> > A bit of a pity when you get a system with more than 200+ cores and
> your
> > testpmd has been built and packaged with RTE_MAX_LCORE == 128.
> >
> > The --lcores does not need to care about the underlying cores, remove
> > this limitation.
> 
> Any comment?
> Thanks.
> 
> 
> --
> David Marchand
> 

I haven't reviewed the patch, but recall that the Mempool library sets up caches per lcore using hardcoded loops going from 0 to RTE_MAX_LCORE, regardless how many lcores are present and assigned to DPDK.

Making rte_max_lcore dynamic (and possibly auto-detected by the EAL) instead of defined at compile time might also be an improvement for systems with fewer cores than RTE_MAX_LCORE. But there are probably a lot of considerations regarding multi-process applications.


Med venlig hilsen / kind regards
- Morten Brørup

  reply	other threads:[~2020-01-14 15:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 15:35 [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE David Marchand
2019-12-02 15:41 ` [dpdk-dev] [PATCH 1/4] eal/windows: fix cpuset macro name David Marchand
2019-12-02 15:42 ` [dpdk-dev] [PATCH 2/4] eal: do not cache lcore detection state David Marchand
2019-12-02 15:42 ` [dpdk-dev] [PATCH 3/4] eal: display all detected cores at startup David Marchand
2019-12-02 15:42 ` [dpdk-dev] [PATCH 4/4] eal: remove limitation on cpuset with --lcores David Marchand
2020-01-14 12:58 ` [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE David Marchand
2020-01-14 15:32   ` Morten Brørup [this message]
2020-01-20 18:37 ` Yigit, Ferruh
2020-01-20 19:35   ` David Marchand
2020-01-21  0:24 ` Thomas Monjalon
2020-02-21  8:04   ` Thomas Monjalon
2020-02-21  8:19     ` Song, Keesang
2020-02-21  9:40       ` David Marchand
2020-02-21 14:48         ` Aaron Conole
2020-02-21 16:38           ` Stephen Hemminger
2020-05-29  3:05     ` Song, Keesang
2020-05-29  3:05       ` Song, Keesang
2020-06-01 21:22         ` Thomas Monjalon
2020-06-01 22:54           ` Song, Keesang
2020-06-09 16:30             ` Song, Keesang
2020-06-09 17:48               ` Luca Boccassi
2020-06-09 21:34                 ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35C60CE1@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=aconole@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).