From: "Morten Brørup" <mb@smartsharesystems.com>
To: "guohongzhi" <guohongzhi1@huawei.com>
Cc: <dev@dpdk.org>, <olivier.matz@6wind.com>,
<konstantin.ananyev@intel.com>, <jiayu.hu@intel.com>,
<ferruh.yigit@intel.com>, <nicolas.chautru@intel.com>,
<cristian.dumitrescu@intel.com>, <zhoujingbin@huawei.com>,
<chenchanghu@huawei.com>, <jerry.lilijun@huawei.com>,
<haifeng.lin@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
Date: Tue, 26 May 2020 11:31:22 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C60FFE@smartserver.smartshare.dk> (raw)
In-Reply-To: <20200526091639.17640-1-guohongzhi1@huawei.com>
guohongzhi,
You must use your real name in the Signed-off-by line.
The signoff must be a real name and not an alias or nickname. For further details, please refer to: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Med venlig hilsen / kind regards
- Morten Brørup
> -----Original Message-----
> From: guohongzhi [mailto:guohongzhi1@huawei.com]
> Sent: Tuesday, May 26, 2020 11:17 AM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Morten Brørup;
> konstantin.ananyev@intel.com; jiayu.hu@intel.com;
> ferruh.yigit@intel.com; nicolas.chautru@intel.com;
> cristian.dumitrescu@intel.com; zhoujingbin@huawei.com;
> chenchanghu@huawei.com; jerry.lilijun@huawei.com;
> haifeng.lin@huawei.com; guohongzhi1@huawei.com
> Subject: [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
>
> 0xffff is invalid for IPv4 checksum(RFC1624)
>
> Fixes: 6006818cfb26 ("net: new checksum functions")
>
> Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Signed-off-by: guohongzhi <guohongzhi1@huawei.com>
> ---
> lib/librte_net/rte_ip.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
> index 1ceb7b7..ece2e43 100644
> --- a/lib/librte_net/rte_ip.h
> +++ b/lib/librte_net/rte_ip.h
> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
> {
> uint16_t cksum;
> cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> - return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> + return (uint16_t)~cksum;
> }
>
> /**
> --
> 2.21.0.windows.1
>
>
next prev parent reply other threads:[~2020-05-26 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 9:16 guohongzhi
2020-05-26 9:31 ` Morten Brørup [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-26 10:08 guohongzhi
2020-06-24 11:53 ` Thomas Monjalon
2020-05-14 1:27 guohongzhi
2020-05-24 15:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35C60FFE@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=chenchanghu@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).