From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6F29A0C46; Fri, 17 Sep 2021 12:57:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4548406B4; Fri, 17 Sep 2021 12:57:44 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 070C940689; Fri, 17 Sep 2021 12:57:42 +0200 (CEST) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Sep 2021 12:57:38 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C61A92@smartserver.smartshare.dk> In-Reply-To: <20210916161040.346703-1-lance.richardson@broadcom.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] net: fix checksum API documentation Thread-Index: AderFW8fcTdnUhe1RM6poZ91gOEqbgAnU4LA References: <20210916161040.346703-1-lance.richardson@broadcom.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Lance Richardson" Cc: , , "Olivier Matz" , "Konstantin Ananyev" , "Andrew Rybchenko" Subject: Re: [dpdk-dev] [PATCH] net: fix checksum API documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Lance Richardson [mailto:lance.richardson@broadcom.com] > Sent: Thursday, 16 September 2021 18.11 >=20 > Minor corrections and improvements to documentation > for checksum APIs. >=20 > Fixes: 6006818cfb26 ("net: new checksum functions") > Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 = checksums") > Cc: stable@dpdk.org > Signed-off-by: Lance Richardson > --- > lib/net/rte_ip.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > index 05948b69b7..fd08ea31b2 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -488,7 +488,7 @@ rte_ipv6_phdr_cksum(const struct rte_ipv6_hdr > *ipv6_hdr, uint64_t ol_flags) > } >=20 > /** > - * @internal Calculate the non-complemented IPv4 L4 checksum > + * @internal Calculate the non-complemented IPv6 L4 checksum > */ > static inline uint16_t > __rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const > void *l4_hdr) > @@ -509,15 +509,15 @@ __rte_ipv6_udptcp_cksum(const struct = rte_ipv6_hdr > *ipv6_hdr, const void *l4_hdr) > /** > * Process the IPv6 UDP or TCP checksum. > * > - * The IPv4 header should not contains options. The layer 4 checksum > - * must be set to 0 in the packet by the caller. > + * The IPv6 header must not be followed by extension headers. The > layer 4 > + * checksum must be set to 0 in the L4 header by the caller. > * > * @param ipv6_hdr > * The pointer to the contiguous IPv6 header. > * @param l4_hdr > * The pointer to the beginning of the L4 header. > * @return > - * The complemented checksum to set in the IP packet. > + * The complemented checksum to set in the L4 header. > */ > static inline uint16_t > rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const void > *l4_hdr) > -- > 2.25.1 Reviewed-by: Morten Br=F8rup