* [Bug 923] i40e PMD contains copy-pasted bug from mempool library
@ 2022-01-20 8:43 bugzilla
2022-01-20 9:06 ` Morten Brørup
2022-07-14 15:46 ` bugzilla
0 siblings, 2 replies; 3+ messages in thread
From: bugzilla @ 2022-01-20 8:43 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=923
Bug ID: 923
Summary: i40e PMD contains copy-pasted bug from mempool library
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: mb@smartsharesystems.com
Target Milestone: ---
The mempool library does not flush its cache correctly, but leaves it full
after flushing.
This bug is fixed in [1], but remains in the i40e PMD, which contains
copy-pasted code [2] from the mempool library.
Other PMDs with copy-pasted code may have the same bug.
[1]
http://inbox.dpdk.org/dev/20220119150301.42583-1-mb@smartsharesystems.com/T/#u
[2]
http://code.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_avx512.c#L919
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Bug 923] i40e PMD contains copy-pasted bug from mempool library
2022-01-20 8:43 [Bug 923] i40e PMD contains copy-pasted bug from mempool library bugzilla
@ 2022-01-20 9:06 ` Morten Brørup
2022-07-14 15:46 ` bugzilla
1 sibling, 0 replies; 3+ messages in thread
From: Morten Brørup @ 2022-01-20 9:06 UTC (permalink / raw)
To: Beilei Xing, Jingjing Wu, Qiming Yang, Qi Zhang
Cc: bugzilla, dev, Olivier Matz, Andrew Rybchenko
To: i40e, iavf, ice PMD maintainers
CC: mempool library maintainers
> From: bugzilla@dpdk.org [mailto:bugzilla@dpdk.org]
> Sent: Thursday, 20 January 2022 09.43
>
> https://bugs.dpdk.org/show_bug.cgi?id=923
>
> Bug ID: 923
> Summary: i40e PMD contains copy-pasted bug from mempool
> library
> Product: DPDK
> Version: unspecified
> Hardware: All
> OS: All
> Status: UNCONFIRMED
> Severity: normal
> Priority: Normal
> Component: ethdev
> Assignee: dev@dpdk.org
> Reporter: mb@smartsharesystems.com
> Target Milestone: ---
>
> The mempool library does not flush its cache correctly, but leaves it
> full
> after flushing.
> This bug is fixed in [1], but remains in the i40e PMD, which contains
> copy-pasted code [2] from the mempool library.
>
> Other PMDs with copy-pasted code may have the same bug.
Grep rte_mempool_default_cache could indicate that the AVX512 code in the iavf and ice PMDs also have this bug.
>
> [1]
> http://inbox.dpdk.org/dev/20220119150301.42583-1-
> mb@smartsharesystems.com/T/#u
>
> [2]
> http://code.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_
> avx512.c#L919
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug 923] i40e PMD contains copy-pasted bug from mempool library
2022-01-20 8:43 [Bug 923] i40e PMD contains copy-pasted bug from mempool library bugzilla
2022-01-20 9:06 ` Morten Brørup
@ 2022-07-14 15:46 ` bugzilla
1 sibling, 0 replies; 3+ messages in thread
From: bugzilla @ 2022-07-14 15:46 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=923
Morten Brørup (mb@smartsharesystems.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #1 from Morten Brørup (mb@smartsharesystems.com) ---
Copy-pasting internal code and not using the mempool API causes more problems
than just the risk of spreading bugs from the library it is copied from to the
destinations where it is copied.
*** This bug has been marked as a duplicate of bug 1052 ***
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-14 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 8:43 [Bug 923] i40e PMD contains copy-pasted bug from mempool library bugzilla
2022-01-20 9:06 ` Morten Brørup
2022-07-14 15:46 ` bugzilla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).