From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B14B5A00C5;
	Mon, 14 Feb 2022 12:10:34 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 50A8B4068C;
	Mon, 14 Feb 2022 12:10:34 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 8DBD34067E
 for <dev@dpdk.org>; Mon, 14 Feb 2022 12:10:33 +0100 (CET)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2 0/2] rte_dump_stack: improvements
Date: Mon, 14 Feb 2022 12:10:30 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86E9B@smartserver.smartshare.dk>
In-Reply-To: <20220212184433.66791-1-stephen@networkplumber.org>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2 0/2] rte_dump_stack: improvements
Thread-Index: AdggQJnZn0tK39MlSEuq4lHi4Iw74ABUdvHw
References: <20220129011039.264377-1-stephen@networkplumber.org>
 <20220212184433.66791-1-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, 12 February 2022 19.45
>=20
> This is update to earlier RFC. Add some more comments and changes
> to have common code for Linux and FreeBSD
>=20
> Stephen Hemminger (2):
>   eal_debug: do not use malloc in rte_dump_stack
>   eal: common rte_dump_stack for both Linux and FreeBSD
>=20
>  lib/eal/freebsd/eal_debug.c | 43 ------------------------
>  lib/eal/freebsd/meson.build |  1 -
>  lib/eal/linux/eal_debug.c   | 43 ------------------------
>  lib/eal/linux/meson.build   |  1 -
>  lib/eal/unix/eal_debug.c    | 65 =
+++++++++++++++++++++++++++++++++++++
>  lib/eal/unix/meson.build    |  5 +--
>  6 files changed, 68 insertions(+), 90 deletions(-)
>  delete mode 100644 lib/eal/freebsd/eal_debug.c
>  delete mode 100644 lib/eal/linux/eal_debug.c
>  create mode 100644 lib/eal/unix/eal_debug.c
>=20
> --
> 2.34.1
>=20

The dladdr() man page mentions that linking with -ldl is required; I =
assume this is already part of the DPDK EAL build system?

For the series,
Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>