From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74398A034E; Mon, 21 Feb 2022 10:35:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18DC84068C; Mon, 21 Feb 2022 10:35:17 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 4B2F04013F for ; Mon, 21 Feb 2022 10:35:16 +0100 (CET) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: disable source pruning Date: Mon, 21 Feb 2022 10:35:11 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86ECE@smartserver.smartshare.dk> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: disable source pruning Thread-Index: AQHXxVHVOtMgwSa1lECrabu3Rl5jN6yebejwgAAOJbA= References: <20211019093835.3492-1-alvinx.zhang@intel.com> <20211020012831.8480-1-alvinx.zhang@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Jiang, YuX" , "Alvin Zhang" , "Xing, Beilei" , "Guo, Junfeng" Cc: , "Zhang, AlvinX" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Jiang, YuX [mailto:yux.jiang@intel.com] > Sent: Monday, 21 February 2022 09.31 >=20 > > From: dev On Behalf Of Alvin Zhang > > Sent: Wednesday, October 20, 2021 9:29 AM > > > > VRRP advertisement packets are dropped on i40e PF devices because > when > > a MAC address is added to a device, packets originating from that = MAC > > address are dropped. > > > > This patch adds a devarg to support disabling source pruning to work > around > > above issue. > > > > Bugzilla ID: 648 > > > > Signed-off-by: Alvin Zhang > > --- > Tested-by: Yu Jiang >=20 > Verified patchset > http://patches.dpdk.org/project/dpdk/patch/20211020012831.8480-1- > alvinx.zhang@intel.com/ on baseline dpdk22.03-rc1:ecc0dd455e > "raw/cnxk_gpio: add option to select subset of GPIOs" > Tested pass on Ethernet Controller XL710 for 40GbE QSFP+ 1583, OS: > Fedora Linux 35/5.14.10-300.fc35.x86_64 > Test step as below: > ./dpdk-testpmd -l 1,2 -n 1 -a 18:00.0,disable_source_pruning=3D1 -- = -i > pkt =3D Ether(src=3D"00:00:5E:00:01:0A")/IP()/Raw("x"*60) > test steps: > 1). testpmd>set verbose 1 > testpmd>start > 2). Send the pkt, the pkt can be received by testpmd > 3). testpmd>mac_addr add 0 00:00:5E:00:01:0A > 4). Re-send the pkt, the pkt still can be received by testpmd. If source pruning is not the default behavior of all NICs, it should be = disabled by default in the i40e NIC too. A NIC shouldn't drop any packets unless it has explicitly been = configured for it! And a NIC shouldn't treat any packets differently = than other NICs do, unless the NIC has explicitly been configured so! Furthermore, I would prefer that configurations for explicitly dropping = certain types of packets is available through runtime APIs, e.g. = RTE_FLOWS, or dedicated functions like = rte_eth_promiscuous_enable/disable(). This patch doesn't support runtime = detection of installed NICs performed by the application. I am very surprised by this default behavior of a NIC. Please confirm = that Source Pruning is at least disabled in Promiscuous mode? -Morten