From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4447A00BE; Wed, 20 Apr 2022 12:10:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 427884068E; Wed, 20 Apr 2022 12:10:48 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id F11C740687 for ; Wed, 20 Apr 2022 12:10:46 +0200 (CEST) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode Date: Wed, 20 Apr 2022 12:10:45 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86FE4@smartserver.smartshare.dk> In-Reply-To: <20220420081650.2043183-6-feifei.wang2@arm.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode Thread-Index: AdhUjxc6ubGc6GI5SVq/POrxiYRnZQADxONw References: <20220420081650.2043183-1-feifei.wang2@arm.com> <20220420081650.2043183-6-feifei.wang2@arm.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Feifei Wang" Cc: , , "Honnappa Nagarahalli" , "Ruifeng Wang" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Feifei Wang [mailto:feifei.wang2@arm.com] > Sent: Wednesday, 20 April 2022 10.17 >=20 > Enable direct rearm mode. The mapping is decided in the data plane > based > on the first packet received. I usually don't care much about l3fwd, but putting configuration changes = in the fast path is just wrong! Also, l3fwd is often used for benchmarking, and this small piece of code = in the fast path will affect benchmark results (although only very = little). Please move it out of the fast path.