From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB7A1A034C; Thu, 28 Apr 2022 15:53:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87F2242819; Thu, 28 Apr 2022 15:53:55 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 9EF5E40E50 for ; Thu, 28 Apr 2022 15:53:54 +0200 (CEST) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Subject: RE: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs Date: Thu, 28 Apr 2022 15:53:52 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8700D@smartserver.smartshare.dk> In-Reply-To: <4aeb8f6a-0537-2f14-240c-bddc74977b7e@huawei.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs Thread-Index: AdhbBVCm4ySiVRyzSE+96NamH+NscgAAR7Og References: <20220416010747.40714-1-fengchengwen@huawei.com> <20220416010747.40714-2-fengchengwen@huawei.com> <20220415183831.2473346b@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35D86FF7@smartserver.smartshare.dk> <4aeb8f6a-0537-2f14-240c-bddc74977b7e@huawei.com> From: =?utf-8?B?TW9ydGVuIEJyw7hydXA=?= To: "fengchengwen" , "Andrew Rybchenko" , "Stephen Hemminger" Cc: , , , , , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org PiBGcm9tOiBmZW5nY2hlbmd3ZW4gW21haWx0bzpmZW5nY2hlbmd3ZW5AaHVhd2VpLmNvbV0NCj4g U2VudDogVGh1cnNkYXksIDI4IEFwcmlsIDIwMjIgMTUuMzkNCj4gDQo+IE9uIDIwMjIvNC8yNSAx ODoxNiwgTW9ydGVuIEJyw7hydXAgd3JvdGU6DQo+ID4+IEZyb206IGZlbmdjaGVuZ3dlbiBbbWFp bHRvOmZlbmdjaGVuZ3dlbkBodWF3ZWkuY29tXQ0KPiA+PiBTZW50OiBTdW5kYXksIDI0IEFwcmls IDIwMjIgMDUuNDUNCj4gPj4NCj4gPj4gVGhlIHJvb3QgY2F1c2UgaXM6IHdoZW4gdGhlIHhzdGF0 cyBpcyBOVUxMIGFuZCBuIGxlc3MgdGhhbiByZXF1aXJlZA0KPiA+PiBudW1iZXIgb2YNCj4gPj4g ZWxlbWVudHMgaXMgemVybywgdGhlIHJldHVybiB2YWx1ZSBvZiBydGVfZXRoX3hzdGF0c19nZXQg aXMNCj4gYW1iaWd1b3VzDQo+ID4+IGZyb20NCj4gPj4gcnRlX2V0aGRldi5oJ3MgZGVjbGFyYXRp b24uDQo+ID4+DQo+ID4+IEJ1dCB0aGUgaW1wbGVtZW50YXRpb24gb2YgcnRlX2V0aF94c3RhdHNf Z2V0IHJldHVybiByZXF1aXJlZCBudW1iZXINCj4gb2YNCj4gPj4gZWxlbWVudHMNCj4gPj4gd2hl biB4c3RhdHMgaXMgTlVMTCBhbmQgbiBsZXNzIHRoYW4gcmVxdWlyZWQgbnVtYmVyIG9mIGVsZW1l bnRzLg0KPiA+Pg0KPiA+PiBUaGVyZSBhcmUgdHdvIG1vZGlmaWNhdGlvbiBzY2hlbWVzOg0KPiA+ PiBhKSB0aGUgdmFsdWUgb2YgeHN0YXRzIGNhbm5vdCBiZSBOVUxMLCBhbmQgdGhlIHZhbHVlIG9m IG4gbXVzdCBiZQ0KPiA+PiBncmVhdGVyIHRoYW4NCj4gPj4gICAgb3IgZXF1YWwgdG8gdGhlIHJl cXVpcmVkIG51bWJlciwgb3RoZXJ3aXNlLCBhbiBlcnJvciBjb2RlIGlzDQo+ID4+IHJldHVybmVk Lg0KPiA+PiBiKSBkZWZpbmUgdGhlIGJlaGF2aW9yIGFzIHRoZSBzYW1lIGFzIHJ0ZV9ldGhfeHN0 YXRzX2dldF9uYW1lcywNCj4gd2hpY2gNCj4gPj4gbWVhbnMgcmV0dXJuDQo+ID4+ICAgIHJlcXVp cmVkIG51bWJlciBvZiBlbGVsZW1lbnQgd2hlbiB4c3RhdHMgaXMgTlVMTCBhbmQgbiBsZXNzIHRo YW4NCj4gPj4gcmVxdWlyZWQgbnVtYmVyDQo+ID4+ICAgIG9mIGVsZW1lbnRzLg0KPiA+Pg0KPiA+ PiBJIHByZWZlciB0aGUgc2NoZW1lIGEgYmVjYXVzZSBydGVfZXRoX3hzdGF0c19nZXQgYW5kDQo+ ID4+IHJ0ZV9ldGhfeHN0YXRzX2dldF9uYW1lIGFyZQ0KPiA+PiBzeW1iaW90aWMsIGFuZCBpdCdz IG5vdCBuZWNlc3NhcnkgdG8gYm90aCBpbXBsZW1lbnQgdGhlIHNhbWUgbG9naWMuDQo+ID4+DQo+ ID4+IEFsc28gZm9yIHNjaGVtZSBhLCB0aGVyZSBpcyBubyBuZWVkIHRvIG1vZGlmeSB0aGUgUE1E DQo+IGltcGxlbWVudGF0aW9uLg0KPiA+Pg0KPiA+PiBXaGF0IGFib3V0IHlvdXIgb3BpbmlvbnMg Pw0KPiA+DQo+ID4gVGhpcyBpcyBhbiBleGNlbGxlbnQgcHJvcG9zYWwuDQo+ID4NCj4gPiBBbmQg aWYgdGhlIGRvY3VtZW50YXRpb24gZm9yIHJ0ZV9ldGhfeHN0YXRzX2dldCgpIHJlZmVycyB0bw0K PiBydGVfZXRoX3hzdGF0c19nZXRfbmFtZXMoKSBmb3IgZ2V0dGluZyB0aGUgbnVtYmVyIG9mIGVs ZW1lbnRzLCBpdCBpcw0KPiBwZXJmZWN0Lg0KPiANCj4gSGkgTW9ydGVuLA0KPiANCj4gICAgSSBk aWQgYSBkZWVwaW4gcmV2aWV3IGFuZCBmb3VuZCB0aGF0IG1hbnkgYXBwbGljYXRpb24gdXNlDQo+ IHJ0ZV9ldGhfeHN0YXRzX2dldChwb3J0X2lkLCBOVUxMLCAwKSwNCj4gYW5kIGFsc28gbWFueSBQ TUQgYWxyZWFkeSBzdXBwb3J0IHJldHVybiByZXF1aXJlZCBudW1iZXIgb2YgZW50cmllcw0KPiB3 aGVuIHhzdGF0cyBpcyBOVUxMLiBTbyBpbg0KPiB0aGUgdjIsIEkgdXNlIHRoZSBtb2RpZmllZCBo bnMzL2lwbjNrZS9tdnBwMi9heGdiZSBQTUQgbWV0aG9kIGFuZA0KPiBleHBsaWNpdCByZXR1cm4g dmFsdWUgd2hlbiB4c3RhdHMNCj4gaXMgTlVMTCBvZiBydGVfZXRoX3hzdGF0cy1nZXQoKS4NCg0K SW5zdGVhZCBvZiBtb2RpZnlpbmcgdGhlIGRyaXZlcnMsIGNvbnNpZGVyIGNvcHlpbmcgdGhpcyBj b2RlIGZyb20gcnRlX2V0aF94c3RhdHNfZ2V0X25hbWVzKCkgdG8gcnRlX2V0aF94c3RhdHNfZ2V0 KCk6DQoNCgljbnRfZXhwZWN0ZWRfZW50cmllcyA9IGV0aF9kZXZfZ2V0X3hzdGF0c19jb3VudChw b3J0X2lkKTsNCglpZiAoeHN0YXRzX25hbWVzID09IE5VTEwgfHwgY250X2V4cGVjdGVkX2VudHJp ZXMgPCAwIHx8DQoJCQkoaW50KXNpemUgPCBjbnRfZXhwZWN0ZWRfZW50cmllcykNCgkJcmV0dXJu IGNudF9leHBlY3RlZF9lbnRyaWVzOw0KDQpKdXN0IGEgc3VnZ2VzdGlvbi4gRWl0aGVyIHNvbHV0 aW9uIGlzIGZpbmUgd2l0aCBtZS4NCg0KPiANCj4gVGhhbmtzLg0KPiANCj4gPg0KPiA+Pg0KPiA+ PiBPbiAyMDIyLzQvMjEgMTQ6NDksIEFuZHJldyBSeWJjaGVua28gd3JvdGU6DQo+ID4+PiBPbiA0 LzE2LzIyIDA0OjM4LCBTdGVwaGVuIEhlbW1pbmdlciB3cm90ZToNCj4gPj4+PiBPbiBTYXQsIDE2 IEFwciAyMDIyIDA5OjA3OjQ1ICswODAwDQo+ID4+Pj4gQ2hlbmd3ZW4gRmVuZyA8ZmVuZ2NoZW5n d2VuQGh1YXdlaS5jb20+IHdyb3RlOg0KPiA+Pj4+DQo+ID4+Pj4+IEN1cnJlbnRseSB0aGUgdGVs ZW1ldHJ5IHhzdGF0cyB1c2VzIHJ0ZV9ldGhfeHN0YXRzX2dldCgpIHRvDQo+ID4+IHJldHJpZXZl DQo+ID4+Pj4+IHRoZSBudW1iZXIgb2YgZWxlbWVudHMuIEJ1dCB0aGUgdmFsdWUgdG8gYmUgcmV0 dXJuZWQgd2hlbiB0aGUNCj4gPj4gcGFyYW1ldGVyDQo+ID4+Pj4+ICd4c3RhdHMnIGlzIE5VTEwg aXMgbm90IHNwZWNpZmllZCwgc29tZSBQTURzIChlZy4NCj4gPj4gaG5zMy9pcG4za2UvbXZwcDIv DQo+ID4+Pj4+IGF4Z2JlKSByZXR1cm4gemVybyB3aGlsZSBvdGhlcnMgcmV0dXJuIHRoZSByZXF1 aXJlZCBudW1iZXIgb2YNCj4gPj4gZWxlbWVudHMuDQo+ID4+Pj4NCj4gPj4+PiBMZXRzIGZpeCB0 aGUgUE1EJ3MgdGhpcyBpbXBhY3RzIG90aGVyIGNvZGUgYXMgd2VsbC4NCj4gPj4+DQo+ID4+PiAr MQ0KPiA+Pj4NCj4gPj4+IC4NCj4gPj4NCj4gPg0KPiANCg0K