From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Tianhao Chai" <cth451@gmail.com>, <dev@dpdk.org>
Subject: RE: [PATCH] rte_dev: allow C-symbol-in-C++ dma operations
Date: Fri, 6 May 2022 19:41:26 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87046@smartserver.smartshare.dk> (raw)
In-Reply-To: <20220505043935.GA312259@cth-desktop-dorm.onozuka.cth451.me>
> From: Tianhao Chai [mailto:cth451@gmail.com]
> Sent: Thursday, 5 May 2022 06.40
> To: dev@dpdk.org
> Cc: Tianhao Chai
> Subject: [PATCH] rte_dev: allow C-symbol-in-C++ dma operations
>
> Currently the "extern C" section ends right before rte_dev_dma_unmap
> and other DMA function declarations, causing some C++ compilers to
> produce C++ mangled symbols to rte_dev_dma_unmap instead of C symbols.
> This leads to build failures later when linking a final executable
> against this object.
>
> The issue is observed on DPDK 22.03 and G++ 11.
>
> Signed-off-by: Tianhao Chai <cth451@gmail.com>
> ---
Acked-by: Morten Brørup <mb@smartsharesystems.com>
prev parent reply other threads:[~2022-05-06 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 4:39 Tianhao Chai
2022-05-05 9:00 ` Bruce Richardson
2022-05-05 9:53 ` David Marchand
2022-05-05 9:43 ` Tyler Retzlaff
2022-05-06 17:41 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87046@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=cth451@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).