From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9D4B5A0543;
	Mon, 13 Jun 2022 11:58:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 814D840150;
	Mon, 13 Jun 2022 11:58:08 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 6C0DB400EF
 for <dev@dpdk.org>; Mon, 13 Jun 2022 11:58:07 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [RFC PATCH v1] net/i40e: put mempool cache out of API
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Mon, 13 Jun 2022 11:58:05 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87117@smartserver.smartshare.dk>
In-Reply-To: <20220613055136.1949784-1-feifei.wang2@arm.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [RFC PATCH v1] net/i40e: put mempool cache out of API
Thread-Index: Adh+6aynqhtnvvqIQ86neJg31FDJtQAIbRew
References: <20220613055136.1949784-1-feifei.wang2@arm.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Feifei Wang" <feifei.wang2@arm.com>,
 "Yuying Zhang" <Yuying.Zhang@intel.com>,
 "Beilei Xing" <beilei.xing@intel.com>,
 "Ruifeng Wang" <ruifeng.wang@arm.com>
Cc: <dev@dpdk.org>, <nd@arm.com>,
 "Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
 "Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
 "Olivier Matz" <olivier.matz@6wind.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Feifei Wang [mailto:feifei.wang2@arm.com]
> Sent: Monday, 13 June 2022 07.52
>=20
> Refer to "i40e_tx_free_bufs_avx512", this patch puts mempool cache
> out of API to free buffers directly. There are two changes different
> with previous version:
> 1. change txep from "i40e_entry" to "i40e_vec_entry"
> 2. put cache out of "mempool_bulk" API to copy buffers into it =
directly
>=20
> Performance Test with l3fwd neon path:
> 		with this patch
> n1sdp:		no perforamnce change
> amper-altra:	+4.0%
>=20
> Suggested-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> ---

Once again bypassing the mempool API and copy-pasting internal code from =
the mempool library to a PMD for performance optimization.

Certainly not happy about it, but it's already done elsewhere, and thus =
we should not deny it here...

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>