DPDK patches and discussions
 help / color / mirror / Atom feed
* RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE requirements
@ 2022-07-14 10:46 Morten Brørup
  2022-07-22 15:24 ` Olivier Matz
  0 siblings, 1 reply; 2+ messages in thread
From: Morten Brørup @ 2022-07-14 10:46 UTC (permalink / raw)
  To: Olivier Matz, dev

Looking at rte_pktmbuf_prefree_seg() [1], the list of described requirements for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE [2] seems incomplete. The following two requirements are missing:
- The mbufs must be direct.
- The mbufs must be non-segmented.

[1] https://elixir.bootlin.com/dpdk/latest/source/lib/mbuf/rte_mbuf.h#L1308
[2] https://elixir.bootlin.com/dpdk/latest/source/lib/ethdev/rte_ethdev.h#L1701


Med venlig hilsen / Kind regards,
-Morten Brørup


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE requirements
  2022-07-14 10:46 RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE requirements Morten Brørup
@ 2022-07-22 15:24 ` Olivier Matz
  0 siblings, 0 replies; 2+ messages in thread
From: Olivier Matz @ 2022-07-22 15:24 UTC (permalink / raw)
  To: Morten Brørup; +Cc: dev

Hi Morten,

Yes, you are right. These 2 conditions are also needed if one wants to use
rte_mbuf_raw_free() or rte_mempool_put*() functions to free the mbufs.

Olivier

On Thu, Jul 14, 2022 at 12:46:24PM +0200, Morten Brørup wrote:
> Looking at rte_pktmbuf_prefree_seg() [1], the list of described requirements for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE [2] seems incomplete. The following two requirements are missing:
> - The mbufs must be direct.
> - The mbufs must be non-segmented.
> 
> [1] https://elixir.bootlin.com/dpdk/latest/source/lib/mbuf/rte_mbuf.h#L1308
> [2] https://elixir.bootlin.com/dpdk/latest/source/lib/ethdev/rte_ethdev.h#L1701
> 
> 
> Med venlig hilsen / Kind regards,
> -Morten Brørup
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-22 15:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 10:46 RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE requirements Morten Brørup
2022-07-22 15:24 ` Olivier Matz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).