From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Lincoln Lavoie" <lylavoie@iol.unh.edu>
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Van Haaren Harry" <harry.van.haaren@intel.com>,
"David Marchand" <david.marchand@redhat.com>,
dpdklab <dpdklab@iol.unh.edu>,
ci@dpdk.org,
"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
"Aaron Conole" <aconole@redhat.com>, dev <dev@dpdk.org>,
dts@dpdk.org
Subject: RE: [dpdklab] RE: rte_service unit test failing randomly
Date: Thu, 6 Oct 2022 14:00:00 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8739F@smartserver.smartshare.dk> (raw)
In-Reply-To: <CAOE1vsO3m120er51kytec5UXOruCWUve7ucuk6suD3xaYuqHBQ@mail.gmail.com>
From: Lincoln Lavoie [mailto:lylavoie@iol.unh.edu]
Sent: Thursday, 6 October 2022 13.07
> On Thu, Oct 6, 2022 at 5:49 AM Morten Brørup <mb@smartsharesystems.com> wrote:
> > From: Mattias Rönnblom [mailto:mattias.ronnblom@ericsson.com]
> > Sent: Thursday, 6 October 2022 10.59
> >
> > On 2022-10-06 10:18, Morten Brørup wrote:
> > >> From: Mattias Rönnblom [mailto:mattias.ronnblom@ericsson.com]
> > >> Sent: Thursday, 6 October 2022 09.51
> > >>
> > >> On 2022-10-06 08:53, Morten Brørup wrote:
> > >
> > > [...]
> > >
> > >>> I have been wondering how accurate the tests really are. Where can
> > I
> > >> see what is being done to ensure that the EAL worker threads are
> > fully
> > >> isolated, and never interrupted by the O/S scheduler or similar?
[...]
> Back to the topic of unit testing, I think we need to consider their purpose and where we expect them to run. Unit tests are run in automated environments, across multiple CI systems, i.e. UNH-IOL Community Lab, GitHub, etc. Those environments are typically virtualized and I don't think the unit tests should require turning down to the level of CPU clock ticks. Those tests are likely better suited to dedicated performance environments, where the complete host is tightly controlled, for the purpose of repeatable and deterministic results on things like packet throughput, etc.
Excellent point, Lincoln. Verifying the performance of the surrounding runtime environment - i.e. the host running the tests - is not unit test material, it belongs with the performance tests.
So, how do I add a test case to the performance test suite? Is there a guide, a reference example, or any other documentation I can look at for inspiration?
NB: This is a good example of yesterday's techboard meeting discussion... I'm a DTS newbie wanting to contribute with a new test case, how do I get started?
If no such documentation exists, could someone please point at a couple of files representing what needs to be added?
next prev parent reply other threads:[~2022-10-06 12:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 19:14 David Marchand
2022-10-05 20:33 ` Mattias Rönnblom
2022-10-05 20:52 ` Thomas Monjalon
2022-10-05 21:33 ` Mattias Rönnblom
2022-10-06 6:53 ` Morten Brørup
2022-10-06 7:04 ` David Marchand
2022-10-06 7:50 ` Morten Brørup
2022-10-06 7:50 ` Mattias Rönnblom
2022-10-06 8:18 ` Morten Brørup
2022-10-06 8:59 ` Mattias Rönnblom
2022-10-06 9:49 ` Morten Brørup
2022-10-06 11:07 ` [dpdklab] " Lincoln Lavoie
2022-10-06 12:00 ` Morten Brørup [this message]
2022-10-06 17:52 ` Honnappa Nagarahalli
2022-10-06 13:51 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D8739F@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=dts@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=lylavoie@iol.unh.edu \
--cc=mattias.ronnblom@ericsson.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).