From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Ankur Dwivedi" <adwivedi@marvell.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <mdr@ashroe.eu>, <orika@nvidia.com>,
<ferruh.yigit@xilinx.com>, <chas3@att.com>, <humin29@huawei.com>,
<linville@tuxdriver.com>, <ciara.loftus@intel.com>,
<qi.z.zhang@intel.com>, <mw@semihalf.com>, <mk@semihalf.com>,
<shaibran@amazon.com>, <evgenys@amazon.com>, <igorch@amazon.com>,
<chandu@amd.com>, <irusskikh@marvell.com>,
<shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,
<john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,
<somnath.kotur@broadcom.com>, <jerinj@marvell.com>,
<mczekaj@marvell.com>, <sthotton@marvell.com>,
<srinivasan@marvell.com>, <hkalra@marvell.com>,
<rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>,
<hyonkim@cisco.com>, <liudongdong3@huawei.com>,
<yisen.zhuang@huawei.com>, <xuanziyang2@huawei.com>,
<cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>,
<simei.su@intel.com>, <wenjun1.wu@intel.com>,
<qiming.yang@intel.com>, <Yuying.Zhang@intel.com>,
<beilei.xing@intel.com>, <xiao.w.wang@intel.com>,
<jingjing.wu@intel.com>, <junfeng.guo@intel.com>,
<rosen.xu@intel.com>, <ndabilpuram@marvell.com>,
<kirankumark@marvell.com>, <skori@marvell.com>,
<skoteshwar@marvell.com>, <lironh@marvell.com>, <zr@semihalf.com>,
<radhac@marvell.com>, <vburru@marvell.com>, <sedara@marvell.com>,
<matan@nvidia.com>, <viacheslavo@nvidia.com>,
<sthemmin@microsoft.com>, <longli@microsoft.com>,
<spinler@cesnet.cz>, <chaoyong.he@corigine.com>,
<niklas.soderlund@corigine.com>, <hemant.agrawal@nxp.com>,
<sachin.saxena@oss.nxp.com>, <g.singh@nxp.com>,
<apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>,
<aboyer@pensando.io>, <rmody@marvell.com>, <shshaikh@marvell.com>,
<dsinghrawat@marvell.com>, <andrew.rybchenko@oktetlabs.ru>,
<jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>,
<jbehrens@vmware.com>, <maxime.coquelin@redhat.com>,
<chenbo.xia@intel.com>, <steven.webster@windriver.com>,
<matt.peters@windriver.com>, <bruce.richardson@intel.com>,
<mtetsuyah@gmail.com>, <grive@u256.net>,
<jasvinder.singh@intel.com>, <cristian.dumitrescu@intel.com>,
<jgrajcia@cisco.com>
Subject: RE: [PATCH v3 1/4] ethdev: add trace points
Date: Thu, 6 Oct 2022 18:03:20 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D873AB@smartserver.smartshare.dk> (raw)
In-Reply-To: <20221006151844.23483-2-adwivedi@marvell.com>
> From: Ankur Dwivedi [mailto:adwivedi@marvell.com]
> Sent: Thursday, 6 October 2022 17.19
>
> Add trace points for ethdev functions.
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
I did my best, but this series needs review by people with direct knowledge about the affected functions.
rte_eth_call_rx/tx_callbacks() are treated as fast path functions, but I think more functions should be too:
rte_eth_tx_buffer_drop_callback() and rte_eth_tx_buffer_count_callback() are certainly fast path functions.
rte_eth_tx_done_cleanup()probably is too.
rte_eth_macaddr_get() could be, but probably isn't. If treated as slow path, it could be noted in its documentation.
I don't know about rte_eth_timesync_read_rx/tx_timestamp(), rte_eth_timesync_adjust/read/write_time() and rte_eth_read_clock().
next prev parent reply other threads:[~2022-10-06 16:03 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 13:44 [PATCH 0/6] add trace points in ethdev library Ankur Dwivedi
2022-08-04 13:44 ` [PATCH 1/6] ethdev: add trace points Ankur Dwivedi
2022-09-12 11:00 ` Andrew Rybchenko
2022-09-13 6:48 ` [EXT] " Ankur Dwivedi
2022-09-13 7:18 ` Andrew Rybchenko
2022-09-26 15:03 ` Andrew Rybchenko
2022-09-28 4:02 ` Jerin Jacob
2022-08-04 13:44 ` [PATCH 2/6] ethdev: add trace points for flow Ankur Dwivedi
2022-08-04 13:44 ` [PATCH 3/6] ethdev: add trace points for mtr Ankur Dwivedi
2022-08-04 13:44 ` [PATCH 4/6] ethdev: add trace points for tm Ankur Dwivedi
2022-08-04 13:44 ` [PATCH 5/6] ethdev: add trace points for driver Ankur Dwivedi
2022-08-04 13:44 ` [PATCH 6/6] devtools: add trace function check in checkpatch Ankur Dwivedi
2022-09-29 10:29 ` [PATCH v2 0/4] add trace points in ethdev library Ankur Dwivedi
2022-09-29 10:29 ` [PATCH v2 1/4] ethdev: add trace points Ankur Dwivedi
2022-10-06 7:09 ` Andrew Rybchenko
2022-10-06 7:24 ` [EXT] " Ankur Dwivedi
2022-10-06 7:27 ` Andrew Rybchenko
2022-10-06 7:43 ` Ankur Dwivedi
2022-10-06 7:50 ` Andrew Rybchenko
2022-10-06 7:57 ` David Marchand
2022-10-12 9:49 ` Jerin Jacob
2022-10-12 9:56 ` David Marchand
2022-09-29 10:29 ` [PATCH v2 2/4] ethdev: add trace points for flow Ankur Dwivedi
2022-09-29 10:29 ` [PATCH v2 3/4] ethdev: add trace points for mtr Ankur Dwivedi
2022-09-29 10:29 ` [PATCH v2 4/4] ethdev: add trace points for tm Ankur Dwivedi
2022-10-06 7:10 ` [PATCH v2 0/4] add trace points in ethdev library Andrew Rybchenko
2022-10-06 7:26 ` [EXT] " Ankur Dwivedi
2022-10-06 7:28 ` Andrew Rybchenko
2022-10-06 7:47 ` Ankur Dwivedi
2022-10-06 12:55 ` Ankur Dwivedi
2022-10-06 15:18 ` [PATCH v3 " Ankur Dwivedi
2022-10-06 15:18 ` [PATCH v3 1/4] ethdev: add trace points Ankur Dwivedi
2022-10-06 16:03 ` Morten Brørup [this message]
2022-10-07 16:23 ` Ankur Dwivedi
2022-10-10 6:39 ` Ankur Dwivedi
2022-12-12 18:34 ` Ferruh Yigit
2022-12-12 18:38 ` Ferruh Yigit
2022-12-14 10:34 ` David Marchand
2022-12-14 11:04 ` Ferruh Yigit
2022-12-13 20:06 ` Ferruh Yigit
2022-12-14 10:40 ` Jerin Jacob
2022-12-14 12:10 ` Ferruh Yigit
2022-12-15 6:49 ` Jerin Jacob
2023-01-12 9:10 ` Thomas Monjalon
2023-01-12 9:43 ` trace point symbols Morten Brørup
2023-01-13 11:22 ` Jerin Jacob
2022-12-14 13:52 ` [EXT] Re: [PATCH v3 1/4] ethdev: add trace points Ankur Dwivedi
2022-10-06 15:18 ` [PATCH v3 2/4] ethdev: add trace points for flow Ankur Dwivedi
2022-10-06 15:18 ` [PATCH v3 3/4] ethdev: add trace points for mtr Ankur Dwivedi
2022-10-06 15:18 ` [PATCH v3 4/4] ethdev: add trace points for tm Ankur Dwivedi
2022-12-22 6:32 ` [PATCH v4 0/6] add trace points in ethdev library Ankur Dwivedi
2022-12-22 6:33 ` [PATCH v4 1/6] eal: trace: add trace point emit for array Ankur Dwivedi
2022-12-22 9:06 ` Sunil Kumar Kori
2022-12-22 10:32 ` Morten Brørup
2022-12-22 15:18 ` Ankur Dwivedi
2022-12-22 6:33 ` [PATCH v4 2/6] ethdev: add trace points for ethdev Ankur Dwivedi
2022-12-22 10:50 ` Morten Brørup
2022-12-22 6:33 ` [PATCH v4 3/6] ethdev: add trace points for remaining functions Ankur Dwivedi
2022-12-22 6:33 ` [PATCH v4 4/6] ethdev: add trace points for flow Ankur Dwivedi
2022-12-22 6:33 ` [PATCH v4 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2022-12-22 6:33 ` [PATCH v4 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-01-12 11:21 ` [PATCH v5 0/6] add trace points in ethdev library Ankur Dwivedi
2023-01-12 11:21 ` [PATCH v5 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-01-12 12:38 ` Morten Brørup
2023-01-12 13:22 ` Ankur Dwivedi
2023-01-12 16:29 ` Sunil Kumar Kori
2023-01-12 16:43 ` Sunil Kumar Kori
2023-01-12 11:21 ` [PATCH v5 2/6] ethdev: add trace points for ethdev Ankur Dwivedi
2023-01-12 16:34 ` Sunil Kumar Kori
2023-01-12 11:21 ` [PATCH v5 3/6] ethdev: add trace points for remaining functions Ankur Dwivedi
2023-01-12 16:38 ` Sunil Kumar Kori
2023-01-13 6:31 ` Ankur Dwivedi
2023-01-13 8:11 ` Sunil Kumar Kori
2023-01-12 11:21 ` [PATCH v5 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-01-12 11:21 ` [PATCH v5 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-01-12 11:21 ` [PATCH v5 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-01-12 17:03 ` [PATCH v5 0/6] add trace points in ethdev library Ferruh Yigit
2023-01-13 6:32 ` [EXT] " Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 " Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-01-20 10:11 ` Morten Brørup
2023-01-23 17:27 ` Ferruh Yigit
2023-01-25 15:02 ` [EXT] " Ankur Dwivedi
2023-01-25 16:09 ` Ferruh Yigit
2023-01-30 13:35 ` Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 2/6] ethdev: add trace points for ethdev (part one) Ankur Dwivedi
2023-01-23 17:28 ` Ferruh Yigit
2023-01-30 16:01 ` [EXT] " Ankur Dwivedi
2023-01-31 18:38 ` Ferruh Yigit
2023-01-31 18:46 ` Jerin Jacob
2023-01-31 22:20 ` Ferruh Yigit
2023-02-01 8:31 ` Jerin Jacob
2023-02-01 10:50 ` Ferruh Yigit
2023-02-01 15:42 ` Ankur Dwivedi
2023-02-02 8:56 ` Ferruh Yigit
2023-02-02 10:20 ` Ankur Dwivedi
2023-02-02 12:52 ` Ferruh Yigit
2023-02-02 13:40 ` Ankur Dwivedi
2023-02-02 13:44 ` Ferruh Yigit
2023-02-02 13:53 ` Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 3/6] ethdev: add trace points for ethdev (part two) Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-01-20 8:40 ` [PATCH v6 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-01-23 9:02 ` [PATCH v7 0/6] add trace points in ethdev library Ankur Dwivedi
2023-01-23 9:02 ` [PATCH v7 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-01-23 13:01 ` Jerin Jacob
2023-01-23 13:08 ` Morten Brørup
2023-01-23 13:39 ` Ankur Dwivedi
2023-01-30 7:30 ` Sunil Kumar Kori
2023-01-30 8:15 ` Morten Brørup
2023-01-30 8:40 ` Sunil Kumar Kori
2023-01-23 9:02 ` [PATCH v7 2/6] ethdev: add trace points for ethdev (part one) Ankur Dwivedi
2023-01-30 8:45 ` Sunil Kumar Kori
2023-01-23 9:02 ` [PATCH v7 3/6] ethdev: add trace points for ethdev (part two) Ankur Dwivedi
2023-01-30 8:47 ` Sunil Kumar Kori
2023-01-23 9:02 ` [PATCH v7 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-02-02 13:52 ` Ori Kam
2023-02-02 13:56 ` Ori Kam
2023-02-02 15:45 ` Ankur Dwivedi
2023-01-23 9:02 ` [PATCH v7 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-01-30 8:50 ` Sunil Kumar Kori
2023-01-23 9:02 ` [PATCH v7 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 0/6] add trace points in ethdev library Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-02-06 14:48 ` David Marchand
2023-02-07 5:08 ` [EXT] " Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 2/6] ethdev: add trace points for ethdev (part one) Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 3/6] ethdev: add trace points for ethdev (part two) Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-02-06 11:58 ` [PATCH v8 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-02-07 6:32 ` [PATCH v9 0/6] add trace points in ethdev library Ankur Dwivedi
2023-02-07 6:32 ` [PATCH v9 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-02-08 1:16 ` Ferruh Yigit
2023-02-07 6:32 ` [PATCH v9 2/6] ethdev: add trace points for ethdev (part one) Ankur Dwivedi
2023-02-08 1:16 ` Ferruh Yigit
2023-02-08 10:30 ` [EXT] " Ankur Dwivedi
2023-02-07 6:32 ` [PATCH v9 3/6] ethdev: add trace points for ethdev (part two) Ankur Dwivedi
2023-02-08 1:20 ` Ferruh Yigit
2023-02-08 10:42 ` [EXT] " Ankur Dwivedi
2023-02-08 11:00 ` Ferruh Yigit
2023-02-08 11:04 ` Ferruh Yigit
2023-02-08 14:15 ` Ankur Dwivedi
2023-02-08 15:05 ` Ferruh Yigit
2023-02-08 15:11 ` Ankur Dwivedi
2023-02-07 6:32 ` [PATCH v9 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-02-07 6:32 ` [PATCH v9 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-02-07 6:32 ` [PATCH v9 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-02-08 13:28 ` [PATCH v10 0/6] add trace points in ethdev library Ankur Dwivedi
2023-02-08 13:28 ` [PATCH v10 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-02-08 13:28 ` [PATCH v10 2/6] ethdev: add trace points for ethdev (part one) Ankur Dwivedi
2023-02-08 13:28 ` [PATCH v10 3/6] ethdev: add trace points for ethdev (part two) Ankur Dwivedi
2023-02-08 13:28 ` [PATCH v10 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-02-08 16:15 ` Ori Kam
2023-02-08 13:28 ` [PATCH v10 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-02-08 13:28 ` [PATCH v10 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-03-15 7:14 ` Yuan, DukaiX
2023-03-16 9:58 ` Ankur Dwivedi
2023-02-08 17:12 ` [PATCH v11 0/6] add trace points in ethdev library Ankur Dwivedi
2023-02-08 17:12 ` [PATCH v11 1/6] eal: trace: add trace point emit for blob Ankur Dwivedi
2023-02-08 17:12 ` [PATCH v11 2/6] ethdev: add trace points for ethdev (part one) Ankur Dwivedi
2023-02-17 7:32 ` Li, WeiyuanX
2023-02-08 17:12 ` [PATCH v11 3/6] ethdev: add trace points for ethdev (part two) Ankur Dwivedi
2023-02-08 20:09 ` Ferruh Yigit
2023-02-08 17:12 ` [PATCH v11 4/6] ethdev: add trace points for flow Ankur Dwivedi
2023-02-08 17:12 ` [PATCH v11 5/6] ethdev: add trace points for mtr Ankur Dwivedi
2023-02-08 17:12 ` [PATCH v11 6/6] ethdev: add trace points for tm Ankur Dwivedi
2023-02-08 20:09 ` [PATCH v11 0/6] add trace points in ethdev library Ferruh Yigit
2023-02-26 18:34 ` Ali Alnubani
2023-02-27 9:38 ` Ankur Dwivedi
2023-01-23 17:30 ` [PATCH v6 " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D873AB@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Yuying.Zhang@intel.com \
--cc=aboyer@pensando.io \
--cc=adwivedi@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=apeksha.gupta@nxp.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chandu@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=chas3@att.com \
--cc=chenbo.xia@intel.com \
--cc=ciara.loftus@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=ed.czeck@atomicrules.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@xilinx.com \
--cc=g.singh@nxp.com \
--cc=grive@u256.net \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=humin29@huawei.com \
--cc=hyonkim@cisco.com \
--cc=igorch@amazon.com \
--cc=irusskikh@marvell.com \
--cc=jasvinder.singh@intel.com \
--cc=jbehrens@vmware.com \
--cc=jerinj@marvell.com \
--cc=jgrajcia@cisco.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=johndale@cisco.com \
--cc=junfeng.guo@intel.com \
--cc=kirankumark@marvell.com \
--cc=linville@tuxdriver.com \
--cc=lironh@marvell.com \
--cc=liudongdong3@huawei.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=mczekaj@marvell.com \
--cc=mdr@ashroe.eu \
--cc=mk@semihalf.com \
--cc=mtetsuyah@gmail.com \
--cc=mw@semihalf.com \
--cc=ndabilpuram@marvell.com \
--cc=niklas.soderlund@corigine.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=radhac@marvell.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sedara@marvell.com \
--cc=shaibran@amazon.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shshaikh@marvell.com \
--cc=simei.su@intel.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=spinler@cesnet.cz \
--cc=srinivasan@marvell.com \
--cc=steven.webster@windriver.com \
--cc=sthemmin@microsoft.com \
--cc=sthotton@marvell.com \
--cc=thomas@monjalon.net \
--cc=vburru@marvell.com \
--cc=viacheslavo@nvidia.com \
--cc=wenjun1.wu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=zhouguoyang@huawei.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).