From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C557EA0548;
	Tue, 11 Oct 2022 21:26:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7A7A140687;
	Tue, 11 Oct 2022 21:26:19 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id C1E0D40146
 for <dev@dpdk.org>; Tue, 11 Oct 2022 21:26:17 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v6 0/4] mempool: fix mempool cache flushing algorithm
Date: Tue, 11 Oct 2022 21:26:14 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D873D1@smartserver.smartshare.dk>
In-Reply-To: <2195692.Dhsi8hcfAM@thomas>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v6 0/4] mempool: fix mempool cache flushing algorithm
Thread-Index: Adjcu+/VfgQpwkyWRfq/ULUoZtFwvwA5+8Dw
References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk>
 <20221009133737.795377-1-andrew.rybchenko@oktetlabs.ru>
 <2195692.Dhsi8hcfAM@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
 "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Cc: "Olivier Matz" <olivier.matz@6wind.com>, <dev@dpdk.org>,
 "Bruce Richardson" <bruce.richardson@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, 10 October 2022 17.21
>=20
> > Andrew Rybchenko (3):
> >   mempool: check driver enqueue result in one place
> >   mempool: avoid usage of term ring on put
> >   mempool: flush cache completely on overflow
> >
> > Morten Br=F8rup (1):
> >   mempool: fix cache flushing algorithm
>=20
> Applied only first 2 "cosmetic" patches as discussed with Andrew.
> The goal is to make some performance tests
> before merging the rest of the series.

I just came to think of this:

Don't test with RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE, because some PMD's =
bypass the mempool library and manipulate the mempool cache structure =
directly, e.g. =
https://elixir.bootlin.com/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_=
vec_avx512.c#L903

The copy-pasted code in those PMDs should probably also be updated to =
reflect the updated mempool library behavior. :-(