From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 92784A0548;
	Tue, 11 Oct 2022 22:30:13 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3AA3D40687;
	Tue, 11 Oct 2022 22:30:13 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id BB06B40146;
 Tue, 11 Oct 2022 22:30:11 +0200 (CEST)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: Copy-pasted code should be updated
Date: Tue, 11 Oct 2022 22:30:09 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D873D2@smartserver.smartshare.dk>
In-Reply-To: <4406925.8F6SAcFxjW@thomas>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Copy-pasted code should be updated
Thread-Index: AdjbWGfEPxN9xhyUTWC3ksfvr03I7QCTnycA
References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk>
 <20221007104450.2567961-1-andrew.rybchenko@oktetlabs.ru>
 <4406925.8F6SAcFxjW@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Yuying Zhang" <Yuying.Zhang@intel.com>,
 "Beilei Xing" <beilei.xing@intel.com>,
 "Jingjing Wu" <jingjing.wu@intel.com>,
 "Qiming Yang" <qiming.yang@intel.com>, "Qi Zhang" <qi.z.zhang@intel.com>
Cc: "Olivier Matz" <olivier.matz@6wind.com>, <dev@dpdk.org>,
 "Thomas Monjalon" <thomas@monjalon.net>,
 "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
 "Feifei Wang" <feifei.wang2@arm.com>, <ruifeng.wang@arm.com>,
 <honnappa.nagarahalli@arm.com>, <nd@arm.com>, <techboard@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Dear Intel PMD maintainers (CC: techboard),

I strongly recommend that you update the code you copy-pasted from the =
mempool library to your PMDs, so they reflect the new and improved =
mempool cache behavior [1]. When choosing to copy-paste code from a core =
library, you should feel obliged to keep your copied code matching the =
source code you copied it from!

Also, as reported in bug #1052, you forgot to copy-paste the =
instrumentation, thereby 1. making the mempool debug statistics invalid =
and 2. omitting the mempool accesses from the trace when using your =
PMDs. :-(

Alternatively, just remove the copy-pasted code and use the mempool =
library's API instead. ;-)

The direct re-arm code also contains copy-pasted mempool cache handling =
code - which was accepted with the argument that the same code was =
already copy-pasted elsewhere. I don't know if the direct re-arm code =
also needs updating... Authors of that patch (CC to this email), please =
coordinate with the PMD maintainers.

PS:  As noted in the 22.11-rc1 release notes, more changes to the =
mempool library [2] may be coming.

[1]: =
https://patches.dpdk.org/project/dpdk/patch/20221007104450.2567961-1-andr=
ew.rybchenko@oktetlabs.ru/

[2]: https://patches.dpdk.org/project/dpdk/list/?series=3D25063

-Morten