From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AF16A00C2; Sun, 30 Oct 2022 09:44:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E0F140693; Sun, 30 Oct 2022 09:44:42 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 15D2340151; Sun, 30 Oct 2022 09:44:41 +0100 (CET) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: Copy-pasted code should be updated Date: Sun, 30 Oct 2022 09:44:37 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87461@smartserver.smartshare.dk> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Copy-pasted code should be updated Thread-Index: AdjbWGfEPxN9xhyUTWC3ksfvr03I7QCTnycAAAT1IAADn/BtYA== References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk> <20221007104450.2567961-1-andrew.rybchenko@oktetlabs.ru> <4406925.8F6SAcFxjW@thomas> <98CBD80474FA8B44BF855DF32C47DC35D873D2@smartserver.smartshare.dk> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Honnappa Nagarahalli" , "Yuying Zhang" , "Beilei Xing" , "Jingjing Wu" , "Qiming Yang" , "Qi Zhang" Cc: "Olivier Matz" , , , "Andrew Rybchenko" , "Feifei Wang" , "Ruifeng Wang" , "nd" , , "Kamalakshitha Aligeri" , "nd" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] > Sent: Tuesday, 11 October 2022 23.48 >=20 > >=20 > > > > Dear Intel PMD maintainers (CC: techboard), > > > > I strongly recommend that you update the code you copy-pasted from > the > > mempool library to your PMDs, so they reflect the new and improved > > mempool cache behavior [1]. When choosing to copy-paste code from a > core > > library, you should feel obliged to keep your copied code matching > the source > > code you copied it from! > > > > Also, as reported in bug #1052, you forgot to copy-paste the > instrumentation, > > thereby 1. making the mempool debug statistics invalid and 2. > omitting the > > mempool accesses from the trace when using your PMDs. :-( > We are working on mempool APIs to expose the per core cache memory to > PMD so that the buffers can be copied directly. We are planning to fix > this duplication as part of that. Is the copy-paste bug fix going to make it for 22.11? Otherwise, these PMDs are managing the mempool cache differently than = the mempool library does. (And the mempool library instrumentation will = remain partially bypassed for these PMDs.) This should be mentioned as a = know bug in the release notes. >=20 > > > > Alternatively, just remove the copy-pasted code and use the mempool > > library's API instead. ;-) > > > > The direct re-arm code also contains copy-pasted mempool cache > handling > > code - which was accepted with the argument that the same code was > > already copy-pasted elsewhere. I don't know if the direct re-arm = code > also > > needs updating... Authors of that patch (CC to this email), please > coordinate > > with the PMD maintainers. > Direct-rearm patch is not accepted yet. >=20 > > > > PS: As noted in the 22.11-rc1 release notes, more changes to the > mempool > > library [2] may be coming. > > > > [1]: > > = https://patches.dpdk.org/project/dpdk/patch/20221007104450.2567961-1- > > andrew.rybchenko@oktetlabs.ru/ > > > > [2]: https://patches.dpdk.org/project/dpdk/list/?series=3D25063 > > > > -Morten >=20