From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1EFABA0540;
	Tue, 13 Dec 2022 21:39:28 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B339D40395;
	Tue, 13 Dec 2022 21:39:27 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 907EE4021D
 for <dev@dpdk.org>; Tue, 13 Dec 2022 21:39:26 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: RE: help with pthread_t deprecation / api changes
Content-Transfer-Encoding: quoted-printable
Date: Tue, 13 Dec 2022 21:39:24 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87595@smartserver.smartshare.dk>
In-Reply-To: <3905723.ZaRXLXkqSa@thomas>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: help with pthread_t deprecation / api changes
Thread-Index: AdkPKeKy1lQs2NivQMmVUhrrmAmoEQACGJhA
References: <20221130225427.GA13682@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <5885133.UjTJXf6HLC@thomas>
 <20221213173843.GA8640@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <3905723.ZaRXLXkqSa@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
 "Tyler Retzlaff" <roretzla@linux.microsoft.com>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>,
 <david.marchand@redhat.com>,
 "Bruce Richardson" <bruce.richardson@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, 13 December 2022 20.34
>=20
> 13/12/2022 18:38, Tyler Retzlaff:
> > Okay, just one final confirmation. This is what we would like?
> >
> > * completely remove the existing rte_thread_getname api.
> >     - by implication this means remove the 1 use of it in eal in
> >       logging.
> >
> > * introduce a new void rte_thread_set_name(rte_thread_t, const char
> *name)
> >   that:
> >     - returns void (does not fail), but in cases it can be detected
> will
> >       log a DEBUG level log message.
> >     - quietly truncates the name (if longer) to
> RTE_MAX_THREAD_NAME_LEN on
> >       all platforms.

Consider also DEBUG logging if truncating the name. Your choice - do or =
don't is fine with me.

> >     - document that it is best effort and only works if the stars
> align
> >       for the target platform.
> >
> > * there will be no unit test, since the set doesn't fail and there =
is
> no
> >   get to validate the set.
> >
> > once i get confirmation i'll update the series.
>=20
> Just my opinion: this proposal is my preference, yes.
> What others think?

LGTM.