From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B2C51A034C;
	Thu, 22 Dec 2022 11:50:58 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 59A79410D0;
	Thu, 22 Dec 2022 11:50:58 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 56B2840FDF
 for <dev@dpdk.org>; Thu, 22 Dec 2022 11:50:57 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v4 2/6] ethdev: add trace points for ethdev
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Thu, 22 Dec 2022 11:50:55 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D875DB@smartserver.smartshare.dk>
In-Reply-To: <20221222063306.3383695-3-adwivedi@marvell.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v4 2/6] ethdev: add trace points for ethdev
Thread-Index: AdkVz9lQnigIJ0VcRbOjSBdTYMkqygAImbhQ
References: <20221006151844.23483-1-adwivedi@marvell.com>
 <20221222063306.3383695-1-adwivedi@marvell.com>
 <20221222063306.3383695-3-adwivedi@marvell.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Ankur Dwivedi" <adwivedi@marvell.com>, <dev@dpdk.org>,
 <jerinj@marvell.com>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>, <mdr@ashroe.eu>,
 <orika@nvidia.com>, <ferruh.yigit@amd.com>, <chas3@att.com>,
 <humin29@huawei.com>, <linville@tuxdriver.com>, <ciara.loftus@intel.com>,
 <qi.z.zhang@intel.com>, <mw@semihalf.com>, <mk@semihalf.com>,
 <shaibran@amazon.com>, <evgenys@amazon.com>, <igorch@amazon.com>,
 <chandu@amd.com>, <irusskikh@marvell.com>,
 <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,
 <john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,
 <somnath.kotur@broadcom.com>, <jerinj@marvell.com>, <mczekaj@marvell.com>,
 <sthotton@marvell.com>, <srinivasan@marvell.com>, <hkalra@marvell.com>,
 <rahul.lakkireddy@chelsio.com>, <johndale@cisco.com>, <hyonkim@cisco.com>,
 <liudongdong3@huawei.com>, <yisen.zhuang@huawei.com>,
 <xuanziyang2@huawei.com>, <cloud.wangxiaoyun@huawei.com>,
 <zhouguoyang@huawei.com>, <simei.su@intel.com>, <wenjun1.wu@intel.com>,
 <qiming.yang@intel.com>, <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,
 <xiao.w.wang@intel.com>, <jingjing.wu@intel.com>, <junfeng.guo@intel.com>,
 <rosen.xu@intel.com>, <ndabilpuram@marvell.com>, <kirankumark@marvell.com>,
 <skori@marvell.com>, <skoteshwar@marvell.com>, <lironh@marvell.com>,
 <zr@semihalf.com>, <radhac@marvell.com>, <vburru@marvell.com>,
 <sedara@marvell.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,
 <longli@microsoft.com>, <spinler@cesnet.cz>, <chaoyong.he@corigine.com>,
 <niklas.soderlund@corigine.com>, <hemant.agrawal@nxp.com>,
 <sachin.saxena@oss.nxp.com>, <g.singh@nxp.com>, <apeksha.gupta@nxp.com>,
 <sachin.saxena@nxp.com>, <aboyer@pensando.io>, <rmody@marvell.com>,
 <shshaikh@marvell.com>, <dsinghrawat@marvell.com>,
 <andrew.rybchenko@oktetlabs.ru>, <jiawenwu@trustnetic.com>,
 <jianwang@trustnetic.com>, <jbehrens@vmware.com>,
 <maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>,
 <steven.webster@windriver.com>, <matt.peters@windriver.com>,
 <bruce.richardson@intel.com>, <mtetsuyah@gmail.com>, <grive@u256.net>,
 <jasvinder.singh@intel.com>, <cristian.dumitrescu@intel.com>,
 <jgrajcia@cisco.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Ankur Dwivedi [mailto:adwivedi@marvell.com]
> Sent: Thursday, 22 December 2022 07.33
>=20
> Adds trace points for ethdev functions.
> Moved the rte_ethdev_trace_rx_burst and rte_ethdev_trace_tx_burst to
> a new file rte_ethdev_trace_fp_burst.h. This is needed to resolve
> cyclic dependency between rte_ethdev.h and rte_ethdev_trace_fp.h.
>=20
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
>  lib/ethdev/ethdev_private.c            |   3 +
>  lib/ethdev/ethdev_trace_points.c       | 193 +++++++++++++++++
>  lib/ethdev/meson.build                 |   1 +
>  lib/ethdev/rte_ethdev.c                | 203 ++++++++++++++++--
>  lib/ethdev/rte_ethdev.h                |   2 +-
>  lib/ethdev/rte_ethdev_trace.h          | 285 =
+++++++++++++++++++++++++
>  lib/ethdev/rte_ethdev_trace_fp.h       | 276 +++++++++++++++++++++++-
>  lib/ethdev/rte_ethdev_trace_fp_burst.h |  44 ++++
>  lib/ethdev/version.map                 |  66 ++++++
>  9 files changed, 1047 insertions(+), 26 deletions(-)
>  create mode 100644 lib/ethdev/rte_ethdev_trace_fp_burst.h
>=20
> diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c
> index 48090c879a..a8f87f22c1 100644
> --- a/lib/ethdev/ethdev_private.c
> +++ b/lib/ethdev/ethdev_private.c
> @@ -5,6 +5,7 @@
>  #include <rte_debug.h>
>=20
>  #include "rte_ethdev.h"
> +#include "rte_ethdev_trace_fp.h"
>  #include "ethdev_driver.h"
>  #include "ethdev_private.h"
>=20
> @@ -297,6 +298,7 @@ rte_eth_call_rx_callbacks(uint16_t port_id,
> uint16_t queue_id,
>  		cb =3D cb->next;
>  	}
>=20
> +	rte_eth_trace_call_rx_callbacks(port_id, queue_id, nb_rx,
> nb_pkts);

Reviewing code like this, it is impossible to determine if this is a =
fast path trace or not, without also looking elsewhere.

Could we please agree on a naming convention to include _fp in fast path =
trace functions and macros?

>  	return nb_rx;
>  }
>=20
> @@ -312,6 +314,7 @@ rte_eth_call_tx_callbacks(uint16_t port_id,
> uint16_t queue_id,
>  		cb =3D cb->next;
>  	}
>=20
> +	rte_eth_trace_call_tx_callbacks(port_id, queue_id, nb_pkts);
>  	return nb_pkts;
>  }
>=20
> diff --git a/lib/ethdev/ethdev_trace_points.c
> b/lib/ethdev/ethdev_trace_points.c
> index 2919409a15..4fea76e0ff 100644
> --- a/lib/ethdev/ethdev_trace_points.c
> +++ b/lib/ethdev/ethdev_trace_points.c
> @@ -5,6 +5,7 @@
>  #include <rte_trace_point_register.h>
>=20
>  #include <rte_ethdev_trace.h>
> +#include <rte_ethdev_trace_fp.h>
>=20
>  RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_configure,
>  	lib.ethdev.configure)
> @@ -29,3 +30,195 @@ =
RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_rx_burst,
>=20
>  RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_tx_burst,
>  	lib.ethdev.tx.burst)
> +
> +RTE_TRACE_POINT_REGISTER(rte_eth_trace_call_rx_callbacks,
> +	lib.ethdev.call_rx_callbacks)

Same comment as above: Reviewing code like this, I cannot immediately =
determine if this is fast path trace or not.