From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 74D27A04FD;
	Tue, 27 Dec 2022 12:16:02 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 01C2E410FC;
	Tue, 27 Dec 2022 12:16:02 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 9A81C40E2D
 for <dev@dpdk.org>; Tue, 27 Dec 2022 12:16:00 +0100 (CET)
Content-class: urn:content-classes:message
Subject: RE: mailmap causing checkpatch warnings
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 27 Dec 2022 12:15:59 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D875FD@smartserver.smartshare.dk>
In-Reply-To: <5631689.DvuYhMxLoT@thomas>
X-MimeOLE: Produced By Microsoft Exchange V6.5
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: mailmap causing checkpatch warnings
Thread-Index: AdkZ3CgRoD0VIHcWROSG3XROCT5jyQAAnkBQ
References: <98CBD80474FA8B44BF855DF32C47DC35D875E7@smartserver.smartshare.dk>
 <5631689.DvuYhMxLoT@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
	<konstantin.ananyev@huawei.com>
Cc: <bruce.richardson@intel.com>, <david.marchand@redhat.com>, <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, 27 December 2022 11.15
>=20
> 24/12/2022 12:05, Morten Br=F8rup:
> > Bruce, David,
> >
> > I just submitted a patch with an Acked-by from Konstantin, using his
> current (Huawei) email address, and it triggered the following
> checkpatch warning:
> > Konstantin Ananyev mail differs from primary mail, please fix the
> commit message or update .mailmap.
>=20
> Do you know how to accept all emails of .mailmap?

It looks like the warning stems from the check_names() function in =
checkpatches.sh [1].

[1]: http://git.dpdk.org/dpdk/tree/devtools/checkpatches.sh

BASH is not my strong side, so I would rather let someone else change =
it.

>=20
> > Some people have more than one active email address, so this
> checkpatch behavior is wrong.

I might be wrong here - perhaps we do want to accept only one primary =
email address in the patch references to contributors, like today, =
instead of all active email addresses of contributors, as I propose.

Accepting only one adds more "paperwork" (updating the mailmap) when =
contributors get a new primary email address. And causes false warnings, =
like here, until the mailmap has been updated.

I am not maintaining the mailmap file, so have no strong preference; but =
false warnings are annoying, and accepting the alternative email =
addresses would prevent them. Hmmm... my proposal is not a perfect =
solution: If a contributor gets a brand new email address, it still =
needs to be added to the mailmap file.

Also, reading up on mailmap, it is also used by "git shortlog -se" to =
emit the primary email addresses. But in the worst case, if the mailmap =
is not updated, it will emit an old email address.

>=20
> Konstantin, what is your main email address?