From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C17524241C; Thu, 19 Jan 2023 20:20:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 862A740223; Thu, 19 Jan 2023 20:20:28 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 975A9400D5 for ; Thu, 19 Jan 2023 20:20:27 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v4 0/9] vhost lock annotations Date: Thu, 19 Jan 2023 20:20:24 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87696@smartserver.smartshare.dk> In-Reply-To: <20230119184620.3195267-1-david.marchand@redhat.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v4 0/9] vhost lock annotations Thread-Index: AdksNlu1nOhap6pvQc660Bk81LjsTQABBp6g References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "David Marchand" , Cc: , , , , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: David Marchand [mailto:david.marchand@redhat.com] > Sent: Thursday, 19 January 2023 19.46 >=20 > vhost internals involves multiple locks to protect data access by > multiple threads. >=20 > This series uses clang thread safety checks [1] to catch issues during > compilation: EAL spinlock, seqlock and rwlock are annotated and vhost > code is instrumented so that clang can statically check correctness. >=20 > Those annotations are quite heavy to maintain because the full path of > code must be annotated (as can be seen in the vhost datapath code), > but I think it is worth using. >=20 > This has been tested against the whole tree and some fixes are already > flying on the mailing list (see [2] for a list). >=20 > If this first series is merged, I will prepare a followup series for > EAL > and other libraries. >=20 >=20 > 1: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html > 2: > = https://patchwork.dpdk.org/bundle/dmarchand/lock_fixes/?state=3D*&archive= > =3Dboth >=20 > -- Lock annotations seems like a good idea. I probably didn't notice the = previous patch versions because the email subject camouflaged them as = "vhost something...", so I skipped them. Series-acked-by: Morten Br=F8rup