From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2E9BF4242B;
	Fri, 20 Jan 2023 10:46:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D513040150;
	Fri, 20 Jan 2023 10:46:53 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id E35C0400D5
 for <dev@dpdk.org>; Fri, 20 Jan 2023 10:46:52 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v6 1/4] lib: add generic support for reading PMU events
Date: Fri, 20 Jan 2023 10:46:50 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8769A@smartserver.smartshare.dk>
In-Reply-To: <20230119233916.4029128-2-tduszynski@marvell.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v6 1/4] lib: add generic support for reading PMU events
Thread-Index: AdksX0+9Py/X8X/rQE2Dl24IqBY9FgAVDWIA
References: <20230110234642.1188550-1-tduszynski@marvell.com>
 <20230119233916.4029128-1-tduszynski@marvell.com>
 <20230119233916.4029128-2-tduszynski@marvell.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Tomasz Duszynski" <tduszynski@marvell.com>, <dev@dpdk.org>,
 "Thomas Monjalon" <thomas@monjalon.net>
Cc: <jerinj@marvell.com>, <Ruifeng.Wang@arm.com>,
 <mattias.ronnblom@ericsson.com>, <zhoumin@loongson.cn>,
 <bruce.richardson@intel.com>, <roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Tomasz Duszynski [mailto:tduszynski@marvell.com]
> Sent: Friday, 20 January 2023 00.39
>=20
> Add support for programming PMU counters and reading their values
> in runtime bypassing kernel completely.
>=20
> This is especially useful in cases where CPU cores are isolated
> (nohz_full) i.e run dedicated tasks. In such cases one cannot use
> standard perf utility without sacrificing latency and performance.
>=20
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> ---

If you insist on passing lcore_id around as a function parameter, the =
function description must mention that the lcore_id parameter must be =
set to rte_lcore_id() for the functions where this is a requirement, =
including all functions that use those functions.

Alternatively, follow my previous suggestion: Omit the lcore_id function =
parameter, and use rte_lcore_id() instead.