From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C73AF424BD;
	Mon, 30 Jan 2023 09:15:21 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5805240EDE;
	Mon, 30 Jan 2023 09:15:21 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id AE16240C35
 for <dev@dpdk.org>; Mon, 30 Jan 2023 09:15:19 +0100 (CET)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v7 1/6] eal: trace: add trace point emit for blob
Date: Mon, 30 Jan 2023 09:15:07 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D876C5@smartserver.smartshare.dk>
In-Reply-To: A<CO6PR18MB3860AB0BCAE3168CA476DE00B4D39@CO6PR18MB3860.namprd18.prod.outlook.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v7 1/6] eal: trace: add trace point emit for blob
Thread-Index: AQHZLwmYccvEhrBEYEGF1HqKr/wqgK62l8RwgAANNAA=
References: <20230120084059.2926575-1-adwivedi@marvell.com>
 <20230123090229.3392071-1-adwivedi@marvell.com>
 <20230123090229.3392071-2-adwivedi@marvell.com>
 A<CO6PR18MB3860AB0BCAE3168CA476DE00B4D39@CO6PR18MB3860.namprd18.prod.outlook.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Sunil Kumar Kori" <skori@marvell.com>,
 "Ankur Dwivedi" <adwivedi@marvell.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>, <mdr@ashroe.eu>,
 <orika@nvidia.com>, <ferruh.yigit@amd.com>, <chas3@att.com>,
 <humin29@huawei.com>, <linville@tuxdriver.com>, <ciara.loftus@intel.com>,
 <qi.z.zhang@intel.com>, <mw@semihalf.com>, <mk@semihalf.com>,
 <shaibran@amazon.com>, <evgenys@amazon.com>, <igorch@amazon.com>,
 <chandu@amd.com>, "Igor Russkikh" <irusskikh@marvell.com>,
 <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>,
 <john.miller@atomicrules.com>, <ajit.khaparde@broadcom.com>,
 <somnath.kotur@broadcom.com>,
 "Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
 "Maciej Czekaj [C]" <mczekaj@marvell.com>,
 "Shijith Thotton" <sthotton@marvell.com>,
 "Srisivasubramanian Srinivasan" <srinivasan@marvell.com>,
 "Harman Kalra" <hkalra@marvell.com>, <rahul.lakkireddy@chelsio.com>,
 <johndale@cisco.com>, <hyonkim@cisco.com>, <liudongdong3@huawei.com>,
 <yisen.zhuang@huawei.com>, <xuanziyang2@huawei.com>,
 <cloud.wangxiaoyun@huawei.com>, <zhouguoyang@huawei.com>,
 <simei.su@intel.com>, <wenjun1.wu@intel.com>, <qiming.yang@intel.com>,
 <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>, <xiao.w.wang@intel.com>,
 <jingjing.wu@intel.com>, <junfeng.guo@intel.com>, <rosen.xu@intel.com>,
 "Nithin Kumar Dabilpuram" <ndabilpuram@marvell.com>,
 "Kiran Kumar Kokkilagadda" <kirankumark@marvell.com>,
 "Satha Koteswara Rao Kottidi" <skoteshwar@marvell.com>,
 "Liron Himi" <lironh@marvell.com>, <zr@semihalf.com>,
 "Radha Chintakuntla" <radhac@marvell.com>,
 "Veerasenareddy Burru" <vburru@marvell.com>,
 "Sathesh B Edara" <sedara@marvell.com>, <matan@nvidia.com>,
 <viacheslavo@nvidia.com>, <longli@microsoft.com>, <spinler@cesnet.cz>,
 <chaoyong.he@corigine.com>, <niklas.soderlund@corigine.com>,
 <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>, <g.singh@nxp.com>,
 <apeksha.gupta@nxp.com>, <sachin.saxena@nxp.com>, <aboyer@pensando.io>,
 "Rasesh Mody" <rmody@marvell.com>, "Shahed Shaikh" <shshaikh@marvell.com>,
 "Devendra Singh Rawat" <dsinghrawat@marvell.com>,
 <andrew.rybchenko@oktetlabs.ru>, <jiawenwu@trustnetic.com>,
 <jianwang@trustnetic.com>, <jbehrens@vmware.com>,
 <maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>,
 <steven.webster@windriver.com>, <matt.peters@windriver.com>,
 <bruce.richardson@intel.com>, <mtetsuyah@gmail.com>, <grive@u256.net>,
 <jasvinder.singh@intel.com>, <cristian.dumitrescu@intel.com>,
 <jgrajcia@cisco.com>, "Ankur Dwivedi" <adwivedi@marvell.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Sunil Kumar Kori [mailto:skori@marvell.com]
> Sent: Monday, 30 January 2023 08.31
>=20
> > From: Ankur Dwivedi <adwivedi@marvell.com>
> > Sent: Monday, January 23, 2023 2:32 PM
> >

[...]

> > +RTE_TRACE_POINT(
> > +	rte_eal_trace_generic_blob,
> > +	RTE_TRACE_POINT_ARGS(void *in, uint8_t len),
> > +	rte_trace_point_emit_blob(in, len);
> > +)
> > +
>=20
> As per documentation rte_eal_trace_generic_blob() will emit 64 bytes
> only i.e. input array cannot be other than uint8_t.
> So will it not be better to make it more readable like
> RTE_TRACE_POINT_ARGS(uint8_t *in, uint8_t len) instead of using void
> *in.

No. Using uint8_t* would cause type conversion problems. The advantage =
of using void* is that it is has no type - which is exactly the purpose =
of a BLOB (which is short for Binary Large OBject). We want to be able =
to pass a pointer to e.g. a structure. Using void* makes that directly =
available.

I didn't notice before, but the const qualifier is missing. It should =
be:

RTE_TRACE_POINT_ARGS(const void *in, uint8_t len),

>=20
> Rest is fine. Already acked above.
>=20
> >  #define RTE_EAL_TRACE_GENERIC_FUNC
> > rte_eal_trace_generic_func(__func__)
> >
> >  /* Interrupt */
>=20
> [snipped]
>=20
> > 2.25.1
>=20