From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F2F47424BD;
	Mon, 30 Jan 2023 09:41:59 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9856340EDE;
	Mon, 30 Jan 2023 09:41:59 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 8F53940C35
 for <dev@dpdk.org>; Mon, 30 Jan 2023 09:41:58 +0100 (CET)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2] net/i40e: support enabling/disabling source pruning
Date: Mon, 30 Jan 2023 09:41:56 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D876C6@smartserver.smartshare.dk>
In-Reply-To: <20230130080916.77274-1-ke1x.zhang@intel.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2] net/i40e: support enabling/disabling source pruning
Thread-Index: Adk0hA/NbZxBjy7rTdagyvU6ewhOwAAAMENg
References: <20230109022027.190627-1-ke1x.zhang@intel.com>
 <20230130080916.77274-1-ke1x.zhang@intel.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Ke Zhang" <ke1x.zhang@intel.com>, <dev@dpdk.org>, <thomas@monjalon.net>,
 <ferruh.yigit@amd.com>, <olivier.matz@6wind.com>, <Yuying.Zhang@intel.com>,
 <beilei.xing@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Ke Zhang [mailto:ke1x.zhang@intel.com]
> Sent: Monday, 30 January 2023 09.09
>=20
> VRRP advertisement packets are dropped on i40e PF devices because
> when a MAC address is added to a device, packets originating from
> that MAC address are dropped.
>=20
> This patch adds a PMD specific API to enable/disable source
> pruning to fix above issue.
>=20
> Bugzilla ID: 648
>=20
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---

This fixes what I considered a bug in the driver, so source pruning is =
now disabled by default. Thank you.

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>

Should rte_pmd_i40e_set_src_prune be added to a maps file? (I'm not sure =
about a PMD specific APIs, so please check.)