DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Simei Su" <simei.su@intel.com>, <qi.z.zhang@intel.com>,
	<junfeng.guo@intel.com>, "Matan Azrad" <matan@nvidia.com>,
	"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
	"Ferruh Yigit" <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, <wenjun1.wu@intel.com>
Subject: RE: [PATCH v2 0/2] net/igc: support launch time offloading
Date: Wed, 1 Feb 2023 09:46:21 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D876E1@smartserver.smartshare.dk> (raw)
In-Reply-To: <20230201073014.431924-1-simei.su@intel.com>

+To: Ferruh, Matan and Viacheslav, regarding feature documentation

> From: Simei Su [mailto:simei.su@intel.com]
> Sent: Wednesday, 1 February 2023 08.30
> 
> [PATCH v2 1/2] expose packet pacing registers
> [PATCH v2 2/2] enable launch time offloading
> 
> v2:
> * Refine title and commit log.
> * Add release notes.
> * Rename variable name.
> 
> Simei Su (2):
>   net/igc/base: expose packet pacing registers
>   net/igc: enable launch time offloading
> 
>  doc/guides/rel_notes/release_23_03.rst |  2 +-
>  drivers/net/igc/base/igc_defines.h     |  9 +++++
>  drivers/net/igc/base/igc_regs.h        |  8 ++++
>  drivers/net/igc/igc_ethdev.c           | 70
> ++++++++++++++++++++++++++++++++++
>  drivers/net/igc/igc_ethdev.h           |  6 ++-
>  drivers/net/igc/igc_txrx.c             | 58 ++++++++++++++++++++++++--
> --
>  drivers/net/igc/igc_txrx.h             |  3 ++
>  7 files changed, 146 insertions(+), 10 deletions(-)
> 
> --
> 2.9.5
> 

Series-acked-by: Morten Brørup <mb@smartsharesystems.com>

Please also note:

This RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP feature should be added to the documentation of NIC features [1] and [2].

[1]: https://doc.dpdk.org/guides/nics/overview.html
[2]: https://doc.dpdk.org/guides/nics/features.html

This should have been done when the feature was introduced by the mlx5 PMD. But apparently, no one thought about it back then. And late is better than never.

Also, adding the feature to the documentation might help deciding on a common name for it.


  parent reply	other threads:[~2023-02-01  8:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  3:47 [PATCH 0/2] net/igc: support Tx timestamp offload Simei Su
2022-12-20  3:47 ` [PATCH 1/2] net/igc/base: " Simei Su
2022-12-20  3:47 ` [PATCH 2/2] net/igc: enable " Simei Su
2023-02-01  7:30 ` [PATCH v2 0/2] net/igc: support launch time offloading Simei Su
2023-02-01  7:30   ` [PATCH v2 1/2] net/igc/base: expose packet pacing registers Simei Su
2023-02-01  7:30   ` [PATCH v2 2/2] net/igc: enable launch time offloading Simei Su
2023-02-01  8:34     ` Zhang, Qi Z
2023-02-01  8:46   ` Morten Brørup [this message]
2023-02-02  7:17   ` [PATCH v3 0/2] net/igc: support " Simei Su
2023-02-02  7:18     ` [PATCH v3 1/2] net/igc/base: expose packet pacing registers Simei Su
2023-02-02  7:18     ` [PATCH v3 2/2] net/igc: enable launch time offloading Simei Su
2023-02-03  0:30       ` Stephen Hemminger
2023-02-03  3:22         ` Su, Simei
2023-02-02  8:46     ` [PATCH v3 0/2] net/igc: support " Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D876E1@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=junfeng.guo@intel.com \
    --cc=matan@nvidia.com \
    --cc=qi.z.zhang@intel.com \
    --cc=simei.su@intel.com \
    --cc=viacheslavo@nvidia.com \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).