From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 534E041D40;
	Wed, 22 Feb 2023 17:32:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 46C27430C4;
	Wed, 22 Feb 2023 17:32:27 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 4EE99430C1
 for <dev@dpdk.org>; Wed, 22 Feb 2023 17:32:26 +0100 (CET)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2 2/2] test/mempool: add zero-copy API's
Date: Wed, 22 Feb 2023 17:32:22 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8776D@smartserver.smartshare.dk>
In-Reply-To: <3410602.WBkqHH8m98@thomas>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2 2/2] test/mempool: add zero-copy API's
Thread-Index: AdlGuu7isp0TPnbSRWi/MqxtwbWG8QAHqTBw
References: <20230209062501.142828-1-kamalakshitha.aligeri@arm.com>
 <2080056.htQpZWrp2x@thomas>
 <98CBD80474FA8B44BF855DF32C47DC35D87768@smartserver.smartshare.dk>
 <3410602.WBkqHH8m98@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>, <olivier.matz@6wind.com>,
 <andrew.rybchenko@oktetlabs.ru>,
 "Kamalakshitha Aligeri" <Kamalakshitha.Aligeri@arm.com>
Cc: <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,
 <bruce.richardson@intel.com>, <konstantin.ananyev@huawei.com>,
 "Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
 "Ruifeng Wang" <Ruifeng.Wang@arm.com>,
 "Feifei Wang" <Feifei.Wang2@arm.com>, <david.marchand@redhat.com>,
 <dev@dpdk.org>, "nd" <nd@arm.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, 22 February 2023 13.41
>=20
> 22/02/2023 09:24, Morten Br=F8rup:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Sent: Wednesday, 22 February 2023 09.01
> > >
> > > 21/02/2023 21:18, Kamalakshitha Aligeri:
> > > > Hi Thomas,
> > > >
> > > > Do you want me to squash the unit tests in the mempool lib patch
> or do I
> > > have to wait for the reviews from mempool maintainers
> > >
> > > Yes I think you can do the squash if Morten agrees.
> >
> > Yes, I agree. And if there are any more changes required before the
> code is accepted by the maintainers, I will let Kamalakshitha make =
those
> changes.
> >
> >
> > How should the different acks/review tags be handled when squashing
> two patches into one?
> >
> > The library patch has:
> >
> > Signed-off-by: Morten Br=F8rup <mb@smartsharesystems.com>
> > Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
> > Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> > Acked-by: Kamalakshitha Aligeri <Kamalakshitha.aligeri@arm.com>
> >
> > And the test patch has:
> >
> > Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> > Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>
>=20
> The cleanest is to remove Reviewed and Acked-by and let reviewer check
> again.
> About the sign-off, you keep both.
> About the authorship, you must choose one.

Kamalakshitha, since I designed and fought for the mempool zero-copy =
API, which I consider the core part of the patch, I would prefer being =
designated as the author of the squashed patch.

I'm no expert at git, but I think the "From" tag indicates the author. =
So the tags in the squashed patch should be:

From: Morten Br=F8rup <mb@smartsharesystems.com>
Signed-off-by: Morten Br=F8rup <mb@smartsharesystems.com>
Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>