From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F17AC4282B; Fri, 24 Mar 2023 08:09:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 859EF406B8; Fri, 24 Mar 2023 08:09:53 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 636944068E for ; Fri, 24 Mar 2023 08:09:52 +0100 (CET) Content-class: urn:content-classes:message Subject: RE: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Fri, 24 Mar 2023 08:09:50 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87808@smartserver.smartshare.dk> X-MimeOLE: Produced By Microsoft Exchange V6.5 In-Reply-To: <1679612036-30773-1-git-send-email-roretzla@linux.microsoft.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics Thread-Index: Adld2l4ShTrqu1uRTg+nkh2540cqeAARRI4g References: <1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com> <1679612036-30773-1-git-send-email-roretzla@linux.microsoft.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Tyler Retzlaff" , Cc: , , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > Sent: Thursday, 23 March 2023 23.54 >=20 > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. >=20 > This series covers the libraries and drivers that are built on = Windows. >=20 > The code has be converted to use the __atomic builtins but there are > additional during conversion i notice that there may be some issues > that need to be addressed. >=20 > I'll comment in the patches where my concerns are so the maintainers > may comment. >=20 > v3: > * style, don't use c99 comments >=20 > v2: > * comment code where optimizations may be possible now that memory > order can be specified. > * comment code where operations should potentially be atomic so that > maintainers can review. > * change a couple of variables labeled as counters to be unsigned. >=20 I didn't see the v3 when ack'ing the v2, so in case v2 is quickly = skipped by maintainers... Series-acked-by: Morten Br=F8rup