From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D161F42C4C;
	Wed,  7 Jun 2023 10:41:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5F02340A84;
	Wed,  7 Jun 2023 10:41:49 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 449F140698
 for <dev@dpdk.org>; Wed,  7 Jun 2023 10:41:47 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 25A0120266;
 Wed,  7 Jun 2023 10:41:46 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH] mempool: optimize get objects with constant n
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Wed, 7 Jun 2023 10:41:42 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87997@smartserver.smartshare.dk>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH] mempool: optimize get objects with constant n
Thread-Index: AdmZF4Mmm/sljaNlTSGTkV2x9l8aSQAAIuxQAADRilA=
References: <20230411064845.37713-1-mb@smartsharesystems.com>
 <1739067.KUTt5R2Mg1@thomas>
 <98CBD80474FA8B44BF855DF32C47DC35D87995@smartserver.smartshare.dk>
 <3590085.WbyNdk4fJJ@thomas> 
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>, <dev@dpdk.org>,
 <olivier.matz@6wind.com>, <andrew.rybchenko@oktetlabs.ru>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Morten Br=F8rup
> Sent: Wednesday, 7 June 2023 10.34
>=20
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, 7 June 2023 10.10
> >

[...]

> > What about doing a general comment at the top of the function,
> > with the assignment of the pointer at the end of the array:
> >
> >     /* The cache is a stack, so copy will be in reverse order. */
> >     cache_objs =3D &cache->objs[cache->len];
> >
> > I could do it on apply if there is an agreement.
> >
> ACK from me.
>=20
> For consistency, please also add the reminder to the two existing =
reverse
> order copy loops in rte_mempool_do_generic_get().

Rubbish! I was looking at the wrong version of the code.

So, plain ACK from me. No further comments!

Sorry. :-!