From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCDED42F50; Wed, 26 Jul 2023 13:47:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4976140E25; Wed, 26 Jul 2023 13:47:05 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 22F0140A79 for ; Wed, 26 Jul 2023 13:47:04 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 32331205EF; Wed, 26 Jul 2023 13:47:02 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v3 1/3] doc: announce bonding macro change Date: Wed, 26 Jul 2023 13:47:00 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87A85@smartserver.smartshare.dk> In-Reply-To: <20230718082856.2235450-2-chaoyong.he@corigine.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3 1/3] doc: announce bonding macro change Thread-Index: Adm5UfTL0HqSj/8XQNaIN/H3XKfQdwGYopbw References: <20230718014809.1779730-1-chaoyong.he@corigine.com> <20230718082856.2235450-1-chaoyong.he@corigine.com> <20230718082856.2235450-2-chaoyong.he@corigine.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Chaoyong He" , Cc: , , "Long Wu" , , "Ferruh Yigit" , "Huisong Li" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Chaoyong He [mailto:chaoyong.he@corigine.com] > Sent: Tuesday, 18 July 2023 10.29 >=20 > From: Long Wu >=20 > In order to support inclusive naming, some of the macro in DPDK will > need to be renamed. Do this through deprecation process now for 23.07. >=20 > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > --- > app/test-pmd/testpmd.c | 2 +- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > drivers/net/bonding/rte_eth_bond_api.c | 6 +++--- > lib/ethdev/rte_ethdev.h | 5 +++-- > 4 files changed, 11 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index c6ad9b18bf..938ca035d4 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -4248,7 +4248,7 @@ uint8_t port_is_bonding_slave(portid_t = slave_pid) > slave_pid); We might want to get rid of the term "slave" in function, parameter and = variable names in testpmd too. This is not important now, and can be = postponed to a later patch. > return 0; > } > - if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port- > >slave_flag =3D=3D 1)) > + if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDING_MEMBER) || (port- > >slave_flag =3D=3D 1)) Can we please standardize on using only "bond" and "BOND" everywhere in = this driver, instead of both "bond" (in function names) and "BONDING" = (in enum values)? The source code file are also named "rte_eth_bond...", while the = directory name is /drivers/net/bonding/. We are about to rename anyway, so let's do it as good as we can. Also, are the bonding and balancing modes defined in = /drivers/net/bonding/rte_eth_bond.h missing the RTE_ prefix, or are they = private? PS: Sorry about joining the discussion late (and possibly ignoring = previous discussions on this). I reacted to the poll for ACKs to this = series.