From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Amit Prakash Shukla" <amitprakashs@marvell.com>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Kevin Laatz" <kevin.laatz@intel.com>,
"Bruce Richardson" <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <conor.walsh@intel.com>,
<vattunuru@marvell.com>, <g.singh@nxp.com>,
<sachin.saxena@oss.nxp.com>, <hemant.agrawal@nxp.com>,
<cheng1.jiang@intel.com>, <ndabilpuram@marvell.com>,
<anoobj@marvell.com>
Subject: RE: [RFC PATCH] dmadev: offload to free source buffer
Date: Wed, 9 Aug 2023 11:07:04 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87AD9@smartserver.smartshare.dk> (raw)
In-Reply-To: <20230809060835.2030833-1-amitprakashs@marvell.com>
> From: Amit Prakash Shukla [mailto:amitprakashs@marvell.com]
> Sent: Wednesday, 9 August 2023 08.09
>
> This changeset adds support in DMA library to free source DMA buffer by
> hardware. On a supported hardware, application can pass on the mempool
> information as part of vchan config when the DMA transfer direction is
> configured as RTE_DMA_DIR_MEM_TO_DEV.
Isn't the DMA source buffer a memory area, and what needs to be freed is the mbuf holding the memory area, i.e. two different pointers?
I like the concept. Something similar might also be useful for RTE_DMA_DIR_MEM_TO_MEM, e.g. packet capture. Although such a use case might require decrementing the mbuf refcount instead of freeing the mbuf directly to the mempool.
PS: It has been a while since I looked at the DMA library, so ignore my comments if I got this wrong.
next prev parent reply other threads:[~2023-08-09 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 6:08 Amit Prakash Shukla
2023-08-09 9:07 ` Morten Brørup [this message]
2023-08-09 14:27 ` Amit Prakash Shukla
2023-08-09 14:48 ` Morten Brørup
2023-08-09 18:11 ` Amit Prakash Shukla
2023-08-10 9:32 ` Morten Brørup
2023-08-10 10:27 ` Amit Prakash Shukla
2023-08-10 11:35 ` Morten Brørup
2023-08-10 12:11 ` Amit Prakash Shukla
2023-08-10 16:53 ` [RFC PATCH v2] " Amit Prakash Shukla
2023-08-10 18:20 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87AD9@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=amitprakashs@marvell.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).