From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F3FCD43082;
	Wed, 16 Aug 2023 18:32:12 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C31BE40ED9;
	Wed, 16 Aug 2023 18:32:12 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 4C881410D0;
 Wed, 16 Aug 2023 18:32:11 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 2C10D205E5;
 Wed, 16 Aug 2023 18:32:11 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v6 01/11] mempool: fix default ops for an empty mempool
Date: Wed, 16 Aug 2023 18:32:07 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87B0C@smartserver.smartshare.dk>
In-Reply-To: <20230816153439.551501-2-bruce.richardson@intel.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v6 01/11] mempool: fix default ops for an empty mempool
Thread-Index: AdnQV0vxm3TiRVtUTBisypE1IgLBrQAB7uMA
References: <20230721115125.55137-1-bruce.richardson@intel.com>
 <20230816153439.551501-1-bruce.richardson@intel.com>
 <20230816153439.551501-2-bruce.richardson@intel.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>,
	<dev@dpdk.org>
Cc: <david.marchand@redhat.com>,
	<probb@iol.unh.edu>,
	<stable@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Wednesday, 16 August 2023 17.34
>=20
> From: David Marchand <david.marchand@redhat.com>
>=20
> An empty mempool's ops were not initialised to a default value wrt to
> what the application requested via the flags parameter.  As
> rte_mempool_create() relies on rte_mempool_create_empty(), simply move
> this ops initialisation to rte_mempool_create_empty().
>=20
> Fixes: aa10457eb4c2 ("mempool: make mempool populate and free api
> public")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

I would have moved it to the exact same location.

Reviewed-by: Morten Br=F8rup <mb@smartsharesystems.com>