From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35F3343086; Wed, 16 Aug 2023 23:08:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5F1B40ED9; Wed, 16 Aug 2023 23:08:52 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id DE90740DDA; Wed, 16 Aug 2023 23:08:51 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id A84F0205E5; Wed, 16 Aug 2023 23:08:51 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API Date: Wed, 16 Aug 2023 23:08:49 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87B12@smartserver.smartshare.dk> In-Reply-To: <20230816210406.GA22350@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API Thread-Index: AdnQhTPK//zdZqelRVexDXb/4eKu7wAAChVA References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1692213549-11786-1-git-send-email-roretzla@linux.microsoft.com> <1692213549-11786-2-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87B11@smartserver.smartshare.dk> <20230816210406.GA22350@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Tyler Retzlaff" Cc: , , "Bruce Richardson" , "Honnappa Nagarahalli" , "Ruifeng Wang" , "Jerin Jacob" , "Sunil Kumar Kori" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Joyce Kong" , "David Christensen" , "Konstantin Ananyev" , "David Hunt" , "Thomas Monjalon" , "David Marchand" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > Sent: Wednesday, 16 August 2023 23.04 >=20 > On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Br=F8rup wrote: > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > Sent: Wednesday, 16 August 2023 21.19 > > > > > > Provide API for atomic operations in the rte namespace that may > > > optionally be configured to use C11 atomics with meson > > > option enable_stdatomics=3Dtrue > > > > > > Signed-off-by: Tyler Retzlaff > > > Reviewed-by: Morten Br=F8rup > > > --- > > > > "#define RTE_ATOMIC(type) [...]" is missing in > lib/eal/include/rte_stdatomic.h, both with and without > RTE_ENABLE_STDATOMIC. > > > > I suggest you keep it together with "#define __rte_atomic [...]". >=20 > this seems to be an error i made in patch submission, somehow i = managed > to drop the changes i made from v2-v3 from the series i submitted i'm > confused how i managed to fat finger it. Happens to me all the time - too often, if you look at my patch = submission track record. ;-) >=20 > i'll submit a new series with the correct changes to rte_stdatomic.h > > > > Please also add descriptions as comments to both (type-qualifier and = - > specifier) in both locations. Your descriptions from the mailing list > discussion are fine. > > >=20 > i'll do this in the v4 commit message Please put the descriptions about their usage in the code as = documentation comments, not in the commit message. >=20 > thanks