From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3784042278; Fri, 1 Sep 2023 17:40:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C10C340285; Fri, 1 Sep 2023 17:40:58 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id C85674014F for ; Fri, 1 Sep 2023 17:40:57 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 9562720716; Fri, 1 Sep 2023 17:40:57 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable Date: Fri, 1 Sep 2023 17:40:55 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87B66@smartserver.smartshare.dk> In-Reply-To: <20230901142332.588856-1-bruce.richardson@intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable Thread-Index: Adnc3+rXAmGaVpI7TKK5y5fyEtxakwACring References: <20230901142332.588856-1-bruce.richardson@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Friday, 1 September 2023 16.24 >=20 > When the user passes a list of desired libraries to build via the > "enable_libs" option, the expectation is that those libraries should = be > part of the build. However, if those libs have either external or > internal dependencies, they still may be silently disabled, for = example: > running "meson setup -Denable_libs=3Dsecurity build" will successfully > run, but the security lib will not be configured as "cryptodev" is > missing. >=20 > We can fix this by setting a flag to indicate when the libraries are > specified via an enable_libs flag. If so, then we error out when a > library is unbuildable, giving a suitable error message. For the above > example case, the "meson setup" run fails with: >=20 > Message: Disabling security [lib/security]: missing internal = dependency > "cryptodev" >=20 > lib/meson.build:218:16: ERROR: Problem encountered: Cannot build = explicitly > requested lib "security". > Please add missing dependency "cryptodev" to "enable_libs" option >=20 > Signed-off-by: Bruce Richardson Acked-by: Morten Br=F8rup