From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB96642278; Fri, 1 Sep 2023 17:41:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF75940299; Fri, 1 Sep 2023 17:41:11 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 147FA40299 for ; Fri, 1 Sep 2023 17:41:11 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id F2C5420716; Fri, 1 Sep 2023 17:41:09 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH 2/2] build: fail if explicitly requested driver is unbuildable Date: Fri, 1 Sep 2023 17:41:08 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87B67@smartserver.smartshare.dk> In-Reply-To: <20230901142332.588856-2-bruce.richardson@intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 2/2] build: fail if explicitly requested driver is unbuildable Thread-Index: Adnc3/GOzo37IRoWQMuf70OJjEpK9QACsKjw References: <20230901142332.588856-1-bruce.richardson@intel.com> <20230901142332.588856-2-bruce.richardson@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" , Cc: "Anatoly Burakov" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Friday, 1 September 2023 16.24 >=20 > When the user passes a list of desired drivers to build via the > "enable_drivers" option, the expectation is that those drivers should = be > part of the build. However, if those drivers have either external or > internal dependencies, they still may be silently disabled, for = example: > running "meson setup -Denable_drivers=3Dnet/iavf build" will = successfully > run, but the iavf net driver will not be configured as "common/iavf" = is > missing. >=20 > We can fix this by setting a flag to indicate when the drivers are > specified via an enable_drivers flag. However, unlike when erroring = out > on missing libs, we don't error out if a driver in unbuildable, unless > the driver name explicitly appears in the "enable_drivers" list. This = is > implemented this way to ensure that wildcarding still works. For > example: we still want to allow "meson setup -Denable_drivers=3Dnet/*" = to > work, configuring only the buildable network drivers. While it's true > that this additional restriction may cause some builds to pass when = they > should fail, e.g. if the wildcard refers only to a single driver, > implementing things this way avoids massive amounts of complexity, and > is still an improvement on the status-quo. >=20 > Suggested-by: Anatoly Burakov > Signed-off-by: Bruce Richardson > --- Acked-by: Morten Br=F8rup