From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCB2E4327C; Fri, 3 Nov 2023 18:31:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ACA6402F2; Fri, 3 Nov 2023 18:31:35 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 70335402D1 for ; Fri, 3 Nov 2023 18:31:34 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 3B6D020723; Fri, 3 Nov 2023 18:31:33 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH 24.03 v2] build: track mandatory rather than optional libs X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Fri, 3 Nov 2023 18:31:30 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9EFCF@smartserver.smartshare.dk> In-Reply-To: <20231103165208.1210182-1-bruce.richardson@intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 24.03 v2] build: track mandatory rather than optional libs Thread-Index: AdoOdiXI29qijsvYRqKTf0nBpARvaQAA1lww References: <20231103162830.593702-1-bruce.richardson@intel.com> <20231103165208.1210182-1-bruce.richardson@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" Cc: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Friday, 3 November 2023 17.52 >=20 > DPDK now has more optional libraries than mandatory ones, so invert = the > list stored in the meson.build file from the optional ones to the > "always_enable" ones. As well as being a shorter list: >=20 > * we can remove the loop building up the "always_enable" list > dynamically from the optional list > * it better aligns with the drivers/meson.build file which maintains = an > always_enable list. >=20 > Signed-off-by: Bruce Richardson Excellent! It really shows how bloated DPDK CORE still is. I would like to see = these go optional: acl - OPTIONAL cmdline - OPTIONAL (if not used by EAL) eal - CORE ethdev - CORE, or OPTIONAL for secondary process fib - OPTIONAL hash - OPTIONAL (if not used by CORE libs) kvargs - OPTIONAL (if not used by EAL) log - CORE lpm - OPTIONAL mbuf - CORE mempool - CORE meter - OPTIONAL net - CORE pci - CORE, or OPTIONAL for secondary process rcu - OPTIONAL (if not used by CORE libs) rib - OPTIONAL ring - CORE stack - OPTIONAL (if not used by CORE libs) telemetry - OPTIONAL timer - OPTIONAL (if not used by CORE libs) Anyway, Acked-by: Morten Br=F8rup