From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 554C9432E1;
	Thu,  9 Nov 2023 08:57:19 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D7F0F4021E;
	Thu,  9 Nov 2023 08:57:18 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 7FEF04013F
 for <dev@dpdk.org>; Thu,  9 Nov 2023 08:57:17 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 4D2A42231C;
 Thu,  9 Nov 2023 08:57:17 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v3 3/5] pcapng: modify timestamp calculation
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Thu, 9 Nov 2023 08:57:15 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9EFFB@smartserver.smartshare.dk>
In-Reply-To: <20231108183557.381955-4-stephen@networkplumber.org>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v3 3/5] pcapng: modify timestamp calculation
Thread-Index: AdoScoLMso6i6DcOT6esIFR9fvVRrQAb7gqQ
References: <20230921042349.104150-1-stephen@networkplumber.org>
 <20231108183557.381955-1-stephen@networkplumber.org>
 <20231108183557.381955-4-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, 8 November 2023 19.36
] pcapng: modify timestamp calculation
>=20
> The computation of timestamp is best done in the part of
> pcapng library that is in secondary process.
> The secondary process is already doing a bunch of system
> calls which makes it not performance sensitive.
>=20
> Simplify the computation of nanoseconds from TSC to a two
> step process which avoids numeric overflow issues. The previous
> code was not thread safe as well.
>=20
> Fixes: c882eb544842 ("pcapng: fix timestamp wrapping in output files")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

This changes the rte_pcapng lib API, but it is marked experimental, so =
should be allowed.

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>