From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DC86143B12;
	Tue, 13 Feb 2024 20:32:47 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 69210402D1;
	Tue, 13 Feb 2024 20:32:47 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 0839040273
 for <dev@dpdk.org>; Tue, 13 Feb 2024 20:32:46 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id CA40A2088F;
 Tue, 13 Feb 2024 20:32:45 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v3 3/3] eal: remove typeof from per lcore macros
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Tue, 13 Feb 2024 20:32:43 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F214@smartserver.smartshare.dk>
In-Reply-To: <1707851523-27998-4-git-send-email-roretzla@linux.microsoft.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v3 3/3] eal: remove typeof from per lcore macros
Thread-Index: AdpesJKZplywupOBSRyIdpMTWAvrrAAArMew
References: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com>
 <1707851523-27998-1-git-send-email-roretzla@linux.microsoft.com>
 <1707851523-27998-4-git-send-email-roretzla@linux.microsoft.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
	<dev@dpdk.org>
Cc: "Kai Ji" <kai.ji@intel.com>,
 "Pablo de Lara" <pablo.de.lara.guarch@intel.com>,
 <bruce.richardson@intel.com>, <david.marchand@redhat.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Tuesday, 13 February 2024 20.12
>=20
> The design of the macros requires a type to be provided to the macro.
>=20
> By expanding the type parameter inside of typeof it also inadvertently
> allows an expression to be used which appears not to have been =
intended
> after evaluating the parameter name and existing macro use.
>=20
> Technically this is an API break but only for applications that were
> using these macros outside of the original design intent.
>=20
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Series-acked-by: Morten Br=F8rup <mb@smartsharesystems.com>