From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E33343AF7; Sat, 17 Feb 2024 19:02:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3DDF400D7; Sat, 17 Feb 2024 19:02:33 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 8812E40042 for ; Sat, 17 Feb 2024 19:02:32 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 65FEA2011D; Sat, 17 Feb 2024 19:02:31 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] net/nfp: add support of UDP fragmentation offload X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Sat, 17 Feb 2024 19:02:30 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F228@smartserver.smartshare.dk> In-Reply-To: <20240217084725.5a1c6f34@hermes.local> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] net/nfp: add support of UDP fragmentation offload Thread-Index: AdphwQCek/ZfAIm+QS2W3bk7MDSAhQACZ4cQ References: <20240217015410.2163102-1-chaoyong.he@corigine.com> <20240217084725.5a1c6f34@hermes.local> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Stephen Hemminger" , "Chaoyong He" Cc: , , "Long Wu" , "Peng Zhang" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Saturday, 17 February 2024 17.47 >=20 > On Sat, 17 Feb 2024 09:54:10 +0800 > Chaoyong He wrote: >=20 > > Add the support of UDP fragmentation offload feature. > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > --- > > drivers/common/nfp/nfp_common_ctrl.h | 1 + > > drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 7 ++++++- > > drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 8 +++++--- > > drivers/net/nfp/nfp_net_common.c | 8 ++++++-- > > 4 files changed, 18 insertions(+), 6 deletions(-) >=20 > Looks like this depends on earlier patch, it does not apply directly = to > main branch. >=20 > > - if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) =3D=3D 0) > > + if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) =3D=3D 0 && > > + (ol_flags & RTE_MBUF_F_TX_UDP_SEG) =3D=3D 0) > > goto clean_txd; >=20 > That is odd indentation style. Not formally... it follows the official DPDK Coding Style [1]. [1]: https://doc.dpdk.org/guides/contributing/coding_style.html#general > Should be: >=20 > if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) =3D=3D 0 && > (ol_flags & RTE_MBUF_F_TX_UDP_SEG) =3D=3D 0) > goto clean_txd; This indentation style is mentioned as an alternative in the guide. But = the example in the guide also uses two tabs for a similar long = comparison. Personally, I also prefer the style suggested by Stephen, so we might = want to update the Coding Style. ;-)