From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 148B243B39;
	Sun, 18 Feb 2024 13:53:44 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 895D94028A;
	Sun, 18 Feb 2024 13:53:43 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 93AFB40262
 for <dev@dpdk.org>; Sun, 18 Feb 2024 13:53:42 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 744D42011D;
 Sun, 18 Feb 2024 13:53:42 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH] eal: provide rte attribute macro for GCC attribute
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Sun, 18 Feb 2024 13:53:40 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F22A@smartserver.smartshare.dk>
In-Reply-To: <3556729.8hb0ThOEGa@thomas>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH] eal: provide rte attribute macro for GCC attribute
Thread-Index: AdpiZWObqU6efWxSS5awiD44lQIB/AAAabtA
References: <1708035618-14090-1-git-send-email-roretzla@linux.microsoft.com>
 <1708035618-14090-2-git-send-email-roretzla@linux.microsoft.com>
 <3556729.8hb0ThOEGa@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
 "Tyler Retzlaff" <roretzla@linux.microsoft.com>
Cc: <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, 18 February 2024 13.24
>=20
> 15/02/2024 23:20, Tyler Retzlaff:
> > Provide a new macro __rte_attribute(a) that when directly used
> > compiles to empty for MSVC and to __attribute__(a) when using
> GCC/LLVM.
> >
> > Replace direct use of __attribute__ in __rte_xxx macros where there
> is
> > existing empty expansion of the macro for MSVC allowing removal of
> > repeated #ifdef RTE_TOOLCHAIN_MSVC per macro to expand empty.
>=20
> I'm not sure it makes sense.
> I prefer seeing clearly what is empty with MSVC.

This topic has previously been discussed in another context - adding =
external libraries [1].

Like you do here, I generally preferred #ifdefs in the code, but the =
majority preferred stubs "promoting improved code readability".

I might argue that Tyler is following that guidance here; and perhaps =
the decision should be reconsidered, now that we have a real-life =
example of how it affects code readability. ;-)

[1]: =
https://inbox.dpdk.org/dev/20240109141009.497807-1-jerinj@marvell.com/