From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 181DC43B57;
	Tue, 20 Feb 2024 14:49:31 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E3B5B4029B;
	Tue, 20 Feb 2024 14:49:30 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 926F040289
 for <dev@dpdk.org>; Tue, 20 Feb 2024 14:49:29 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 72D4620893;
 Tue, 20 Feb 2024 14:49:29 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v5] mempool: test performance with larger bursts
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Tue, 20 Feb 2024 14:49:28 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F237@smartserver.smartshare.dk>
In-Reply-To: <3522622.fIoEIV5pvu@thomas>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v5] mempool: test performance with larger bursts
Thread-Index: AdpilMvSGm6GCU8XSaO46catyj5UDgBbX0ag
References: <20240121045249.22465-1-mb@smartsharesystems.com>
 <20240124112134.85549-1-mb@smartsharesystems.com> <3522622.fIoEIV5pvu@thomas>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>
Cc: <andrew.rybchenko@oktetlabs.ru>, <fengchengwen@huawei.com>, <dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, 18 February 2024 19.04
>=20
> 24/01/2024 12:21, Morten Br=F8rup:
> > --- a/app/test/test_mempool_perf.c
> > +++ b/app/test/test_mempool_perf.c
> > @@ -1,6 +1,6 @@
> >  /* SPDX-License-Identifier: BSD-3-Clause
> >   * Copyright(c) 2010-2014 Intel Corporation
> > - * Copyright(c) 2022 SmartShare Systems
> > + * Copyright(c) 2022-2024 SmartShare Systems
>=20
> You don't need to update copyright year.
> The first year is the only important one.
>=20
> reading: https://matija.suklje.name/how-and-why-to-properly-write-
> copyright-statements-in-your-code#why-not-bump-the-year-on-change

Thank you, Thomas. Very informative.
Will fix in next version.

>=20
> [...]
> >  REGISTER_PERF_TEST(mempool_perf_autotest, test_mempool_perf);
> > +REGISTER_PERF_TEST(mempool_perf_autotest_1core,
> test_mempool_perf_1core);
> > +REGISTER_PERF_TEST(mempool_perf_autotest_2cores,
> test_mempool_perf_2cores);
>=20
> How do we make sure the test is skipped if we have only 1 core?

Good point. Will fix in next version.

>=20
> > +REGISTER_PERF_TEST(mempool_perf_autotest_allcores,
> test_mempool_perf_allcores);
>=20
> How the test duration is changed after this patch?
>=20

On my test machine, the expanded test parameter set increased the =
duration of one test run from 20 minutes to 100 minutes.
Before the patch, all three test runs were always executed, i.e. a total =
duration of 60 minutes.

In other words:
The expanded test parameter set increased the test run duration by =
factor five.
Introducing the ability to optionally only test with a specific number =
of lcores reduced the total test duration to a third.